Then I ran the following command in the python console:
Code: Select all
Of course it's rather ugly and badly in need of CSS styling.
Code: Select all
Meeting license terms might be painful, especially when using a lot of external libraries.
I wouldn't try to fetch the wiki page at build time because you have almost no control if its content has changed in the meantime and if it's still correct. Because the license file will be changed very rarely I vote to add an extra static file to the repository.yorik wrote: ↑Mon Feb 05, 2018 10:22 amNormand's solution seems good, but we would need a script that runs at build time to fetch that page from the wiki everytime, to make sure it is using the most up-to-date version. Plus, if FreeCAD is built without webkit, that page will be unavailable.
But since OCC is by far our most important third-party library, and, I believe, the only one that doesn't use standard LGPL (it has an additional clause), we might as well simply add the full OCC license text in our about dialog (an extra tab maybe?). That would be an easy way to solve too... Would that be OK for everybody?
That's what I originally had in mind. But I didn't think about what would happen if FreeCAD isn't compiled with webkit. I think the current 0.16 in the Debian repo is like that...
The HTML page with the license texts (that CAD Assistant uses and I want to adjust for FreeCAD) doesn't require any CSS stuff or the like. Therefore, the lightweight QTextBrowser class which is not based on Webkit absolutely suffices. Indeed, with my self-compiled Qt 5.6 on Windows I don't have the Webkit module as the build process always failed. So, a solution that doesn't require Webkit would be the best.NormandC wrote: ↑Tue Feb 06, 2018 3:57 amThat's what I originally had in mind. But I didn't think about what would happen if FreeCAD isn't compiled with webkit. I think the current 0.16 in the Debian repo is like that...