github some cool feature

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
Kunda1
Posts: 7353
Joined: Thu Jan 05, 2017 9:03 pm

Re: github some cool feature

Postby Kunda1 » Thu Feb 01, 2018 2:10 pm

sgrogan wrote:
Wed Jan 31, 2018 9:42 pm
chrisb wrote:
Wed Jan 31, 2018 12:44 am
And you are right, that is exactly the usecase I had in mind. Perhaps the development download page could tell which version the current ppa has.
Not directly without some fancy webhooks I don't know.
AFAIK, the limitation of why we don't have webhooks is due to access and server software of freecadweb.org
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
sgrogan
Posts: 5813
Joined: Wed Oct 22, 2014 5:02 pm

Re: github some cool feature

Postby sgrogan » Thu Feb 01, 2018 11:29 pm

chrisb wrote:
Thu Feb 01, 2018 1:53 am
Yes. And thanks for the effort.
https://github.com/FreeCAD/FreeCAD/rele ... g/0.17_pre
It can be improved. I wish we could use bernd's trick to start counting commits.
triplus
Posts: 9431
Joined: Mon Dec 12, 2011 4:45 pm

Re: github some cool feature

Postby triplus » Fri Feb 02, 2018 1:15 pm

sgrogan wrote:
Thu Feb 01, 2018 11:29 pm
https://github.com/FreeCAD/FreeCAD/rele ... g/0.17_pre
It can be improved. I wish we could use bernd's trick to start counting commits.
If i click on that link it won't work without being signed in. But all in all what are you guys trying to achieve? Is this effort related to the fact AppImage doesn't have a full version information available?
chrisb
Posts: 24399
Joined: Tue Mar 17, 2015 9:14 am

Re: github some cool feature

Postby chrisb » Fri Feb 02, 2018 2:38 pm

It's not about AppImage for me. I had hoped for a possibility to know the version number of the daily ppa before installing.
User avatar
sgrogan
Posts: 5813
Joined: Wed Oct 22, 2014 5:02 pm

Re: github some cool feature

Postby sgrogan » Fri Feb 02, 2018 5:58 pm

triplus wrote:
Fri Feb 02, 2018 1:15 pm
If i click on that link it won't work without being signed in. But all in all what are you guys trying to achieve? Is this effort related to the fact AppImage doesn't have a full version information available?
It works for me when not signed in, how about you @chrisb?
The idea is to be able to quickly determine if a given commit is in the published binary. The Appimage and PPA don't have any version or commit hash info in the package. Knowing the version/hash is only part of the solution.
chrisb
Posts: 24399
Joined: Tue Mar 17, 2015 9:14 am

Re: github some cool feature

Postby chrisb » Fri Feb 02, 2018 9:14 pm

sgrogan wrote:
Fri Feb 02, 2018 5:58 pm
It works for me when not signed in, how about you @chrisb?
Independent of login it shows "6513 commits to master since this release".
User avatar
sgrogan
Posts: 5813
Joined: Wed Oct 22, 2014 5:02 pm

Re: github some cool feature

Postby sgrogan » Thu Feb 08, 2018 12:16 am

triplus wrote:
Fri Feb 02, 2018 1:15 pm
Is this effort related to the fact AppImage doesn't have a full version information available?
Thanks triplus ;)
triplus
Posts: 9431
Joined: Mon Dec 12, 2011 4:45 pm

Re: github some cool feature

Postby triplus » Fri Feb 09, 2018 12:08 am

sgrogan wrote:
Fri Feb 02, 2018 5:58 pm
It works for me when not signed in, how about you @chrisb?
Sorry should have been more verbose. This link:

https://git.launchpad.net/%7Efreecad-ma ... /Version.h

That is what i get if i click on the link directly (on GitHub using Firefox). If instead i use copy/paste procedure it works as expected:

https://git.launchpad.net/~freecad-main ... /Version.h

Notice the "~" to "%7E" conversion in the url.
sgrogan wrote:
Thu Feb 08, 2018 12:16 am
triplus wrote:
Fri Feb 02, 2018 1:15 pm
Is this effort related to the fact AppImage doesn't have a full version information available?
Thanks triplus ;)
You're welcome.