porting to smesh 8.3

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: porting to smesh 8.3

Post by looo »

Thanks, so compiling smesh with libmed won't solve the issues I had with netgen and mefisto... But anyway I will try to convince pyocct to include libmed for the next release.
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: porting to smesh 8.3

Post by looo »

bernd wrote:related commits:
thanks for this hint. After inclusion of these commits, netgen and mefisto seem to work again.

I created a PR to get some feedback about the diff [1]. The remaining problem is the backward compatibility... But maybe someone else can have a look at this. Also I think it wouldn't be the worst idea to only support the externalized smesh...

[1] https://github.com/FreeCAD/FreeCAD/pull/1407
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: porting to smesh 8.3

Post by looo »

Finally it seems like the basic tests are working...
Bildschirmfoto vom 2018-04-25 11-13-49.png
Bildschirmfoto vom 2018-04-25 11-13-49.png (23.76 KiB) Viewed 1251 times
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: porting to smesh 8.3

Post by ickby »

that is awesome!
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: porting to smesh 8.3

Post by bernd »

ickby wrote: Wed Apr 25, 2018 10:39 amthat is awesome!
:shock: :D


HoWil wrote:ping
Wilfried you will be very very happy ...
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: porting to smesh 8.3

Post by bernd »

looo wrote: Sun Apr 15, 2018 8:34 pm
I wrote:Is libmed needed anywhere in FreeCAD or is it another dependency to make building FreeCAD more difficult?
does anybody know why we need the libmed library???
AFAIK to import and export med Mesh files. This was added from vejmarie. I do not know of someone else who ever talked about med file format.

bernd
HoWil
Veteran
Posts: 1279
Joined: Sun Jun 14, 2015 7:31 pm
Location: Austria

Re: porting to smesh 8.3

Post by HoWil »

looo wrote: Fri Mar 30, 2018 5:00 am but meshing a cube results in a crash
looo wrote: Wed Apr 25, 2018 9:18 am Finally it seems like the basic tests are working...
Bildschirmfoto vom 2018-04-25 11-13-49.png
Nice! So are you now able to mesh a cube?
BR,
HoWil
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: porting to smesh 8.3

Post by looo »

yes, no crash anymore. This was related to a patch for netgen which was added for pyocct, but is not really necessary. I hope we can now share the sources/ dependencies with pyocct.

For netgen we still use a patch from the salome project:
https://github.com/conda-forge/netgen-f ... lome.patch
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: porting to smesh 8.3

Post by looo »

I post this here again:

the update to newer smesh8.3 breaks the unv import and gmsh-meshing tool (as it uses .unv import internally)
maybe this one will help?: https://github.com/FreeCAD/FreeCAD/comm ... 0d7cdd82f5


references:
https://forum.freecadweb.org/viewtopic. ... 80#p231430
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: porting to smesh 8.3

Post by looo »

the strange thing is that the unv file stores the mesh not in the order [1,2,3,4...10].
With the included smesh of FreeCAD:
1 7 3 6 2 5 8 10 9 4
(this order works)

with the external smesh 8.3:
1 3 2 4 7 6 5 8 10 9
which seems to be a wrong order

I wonder how the order is recrated in the working example. Is this done on SMESH side or on FreeCAD side?
Post Reply