[PR] Sketcher Solver Improvements
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
[PR] Sketcher Solver Improvements
I posted here:
https://forum.freecadweb.org/viewtopic. ... 17#p229548
and maybe it got a little bit unnoticed.
I am looking for volunteers to test this branch against the bugs of the GCS project in the tracker:
https://freecadweb.org/tracker/view_all_bug_page.php
I am also looking for volunteers to run it in a small project and see if any unexpected solver issue arises (detection of redundants)...
I think it would be great to test it before merging, as there may still be room for further improvements.
EDIT: Fixes (so far):
#3434
#1557
#2797 (the remaining part, i.e. the not notification of the redundancy)
Probably the fix for (reporter notified for feedback):
#2342
#3223
https://forum.freecadweb.org/viewtopic. ... 17#p229548
and maybe it got a little bit unnoticed.
I am looking for volunteers to test this branch against the bugs of the GCS project in the tracker:
https://freecadweb.org/tracker/view_all_bug_page.php
I am also looking for volunteers to run it in a small project and see if any unexpected solver issue arises (detection of redundants)...
I think it would be great to test it before merging, as there may still be room for further improvements.
EDIT: Fixes (so far):
#3434
#1557
#2797 (the remaining part, i.e. the not notification of the redundancy)
Probably the fix for (reporter notified for feedback):
#2342
#3223
Last edited by abdullah on Sun Apr 29, 2018 5:49 am, edited 5 times in total.
Re: [request for testing] Sketcher Solver Improvements
I am getting a build failure on windowsabdullah wrote: ↑Wed Apr 25, 2018 12:20 pm I am looking for volunteers to test this branch against the bugs of the GCS project in the tracker:
https://freecadweb.org/tracker/view_all_bug_page.php
Code: Select all
1>c:\users\chris\desktop\fclibs_vc12_x64\freecadlibs_11.10a_x64_vc12\include\eigen3\eigen\src/Core/Matrix.h(277): error C2338: YOU_MIXED_DIFFERENT_NUMERIC_TYPES__YOU_NEED_TO_USE_THE_CAST_METHOD_OF_MATRIXBASE_TO_CAST_NUMERIC_TYPES_EXPLICITLY
1> C:\Users\Chris\GitHub\FreeCAD\src\Mod\Sketcher\App\planegcs\GCS.cpp(3874) : see reference to function template instantiation 'Eigen::Matrix<long,1,-1,1,1,-1>::Matrix<Derived>(const Eigen::MatrixBase<Derived> &)' being compiled
1> with
1> [
1> Derived=Eigen::Matrix<__int64,1,-1,1,1,-1>
1> ]
1> C:\Users\Chris\GitHub\FreeCAD\src\Mod\Sketcher\App\planegcs\GCS.cpp(3874) : see reference to function template instantiation 'Eigen::Matrix<long,1,-1,1,1,-1>::Matrix<Derived>(const Eigen::MatrixBase<Derived> &)' being compiled
1> with
1> [
1> Derived=Eigen::Matrix<__int64,1,-1,1,1,-1>
1> ]
"fight the good fight"
Re: [request for testing] Sketcher Solver Improvements
I am using 3.3.4, but I have to make it work with earlier versions. Do not update it. I will try to figure out what is happening.sgrogan wrote: ↑Wed Apr 25, 2018 10:08 pmI am getting a build failure on windowsabdullah wrote: ↑Wed Apr 25, 2018 12:20 pm I am looking for volunteers to test this branch against the bugs of the GCS project in the tracker:
https://freecadweb.org/tracker/view_all_bug_page.phpDo I need to update Eigen3, I think I have 3.2.5.Code: Select all
1>c:\users\chris\desktop\fclibs_vc12_x64\freecadlibs_11.10a_x64_vc12\include\eigen3\eigen\src/Core/Matrix.h(277): error C2338: YOU_MIXED_DIFFERENT_NUMERIC_TYPES__YOU_NEED_TO_USE_THE_CAST_METHOD_OF_MATRIXBASE_TO_CAST_NUMERIC_TYPES_EXPLICITLY 1> C:\Users\Chris\GitHub\FreeCAD\src\Mod\Sketcher\App\planegcs\GCS.cpp(3874) : see reference to function template instantiation 'Eigen::Matrix<long,1,-1,1,1,-1>::Matrix<Derived>(const Eigen::MatrixBase<Derived> &)' being compiled 1> with 1> [ 1> Derived=Eigen::Matrix<__int64,1,-1,1,1,-1> 1> ] 1> C:\Users\Chris\GitHub\FreeCAD\src\Mod\Sketcher\App\planegcs\GCS.cpp(3874) : see reference to function template instantiation 'Eigen::Matrix<long,1,-1,1,1,-1>::Matrix<Derived>(const Eigen::MatrixBase<Derived> &)' being compiled 1> with 1> [ 1> Derived=Eigen::Matrix<__int64,1,-1,1,1,-1> 1> ]
Re: [request for testing] Sketcher Solver Improvements
That's the ticket!
https://github.com/sgrogan/FreeCAD/rele ... /redundant
Your branch name is a mouth full
"fight the good fight"
Re: [request for testing] Sketcher Solver Improvements
Thank you!! Now Windows users have no excuse to participate in the testing:sgrogan wrote: ↑Thu Apr 26, 2018 9:40 pmThat's the ticket!
https://github.com/sgrogan/FreeCAD/rele ... /redundant
https://forum.freecadweb.org/viewtopic. ... 17#p229548
While testing, you can also give some feedback on the DoF finder (the solver messages saying the DoF are a hyperlink that selects the elements contributing to the DoFs).
Today I think I will have some time, maybe I try to use realthunder's script to generate ubuntu builds...
Indeed. I have very bad memory. I need something very descriptive. It is also good, given that the Sketcher DoF finder, as in the PR will not make it into master, as we have just discovered it does not compile with MSC, maybe what is finally merged is this branch that is built on top of it...
Re: [request for testing] Sketcher Solver Improvements
This a first effort of an appimage using realthunder's script:
https://github.com/abdullahtahiriyo/Fre ... 0.11-alpha
I am a total newbie to Appimage and I ran into some issues while building it, so tell me if it does not work.
Edit: Updated appimage
https://github.com/abdullahtahiriyo/Fre ... 0.11-alpha
I am a total newbie to Appimage and I ran into some issues while building it, so tell me if it does not work.
Edit: Updated appimage
Last edited by abdullah on Fri Apr 27, 2018 7:16 pm, edited 1 time in total.
Re: [request for testing] Sketcher Solver Improvements
I would rather say that Windows users have no excuse to not participate in the testing
Thank you very much! Will test right away.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: [request for testing] Sketcher Solver Improvements
AppImage runs, First redundancy test was successful. More later.
Thanks!
Thanks!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: [request for testing] Sketcher Solver Improvements
Good to know!
realthunder did a good job with that script. I did not know it this morning, but you just indicate which branch from which repo, and it does not even matter if it is your repo or not. The thing clones the repo and makes the package. You do need some disk space for the whole thing, I think it took more than 2.5 GB. But that is it.
If you run GCS tickets, it would be great to known which ones are solved and which ones were tested but not solved. This way I can concentrate in the ones that are not solved.
Thanks for testing