[BUG?] Cropped icons

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
pablogil
Posts: 842
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

[BUG?] Cropped icons

Postby pablogil » Sun May 20, 2018 11:56 am

Hi,

Since a time, and I think only in Qt5 builds, I'm experiencing the following: my laptop has a retina display (macbook pro) and when placing the FreeCAD window in that screen all icons show correctly. But if I connect an external monitor with regular pixel density and place the FreeCAD window in that screen then the "file" and "view" tools scale and crop like the following screenshot:
normal.jpg
normal.jpg (48.27 KiB) Viewed 1459 times
If I place back the FreeCAD window to the retina display it refreshes and show the icons correctly, but if place it back to the external monitor then they are back scaled and cropped.

The curious thing is that I have checked that if I use @triplus "IconThemes" addon it does correctly scale the icons:
custom.jpg
custom.jpg (37.57 KiB) Viewed 1459 times
Any idea? is it a bug or maybe a problem with icons sizes? by now I can't build a custom FreeCAD so I can't try it out by myself...
Thanks
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
peterl94
Posts: 1001
Joined: Thu May 23, 2013 7:31 pm
Location: United States

Re: [BUG?] Cropped icons

Postby peterl94 » Sun May 20, 2018 6:43 pm

You reported this issue quite a while ago, but I guess no one has had time to fix it. https://freecadweb.org/tracker/view.php?id=3130
triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: [BUG?] Cropped icons

Postby triplus » Tue May 22, 2018 12:46 pm

Hi Pablo.

I can take a look at weekend. To see if anything obvious is at play. If i understand the issue correctly this only happens for the commands located on the View toolbar?
User avatar
pablogil
Posts: 842
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: [BUG?] Cropped icons

Postby pablogil » Tue May 22, 2018 12:57 pm

peterl94 wrote:
Sun May 20, 2018 6:43 pm
You reported this issue quite a while ago, but I guess no one has had time to fix it. https://freecadweb.org/tracker/view.php?id=3130
The problem is the same one but not the approach... I mean, I have discovered that with IconThemes the problem is solved but I don't know why so I thought it was a nice option to ask triplus about it. Maybe for his is trivial and he can solve it easily...
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
User avatar
pablogil
Posts: 842
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: [BUG?] Cropped icons

Postby pablogil » Tue May 22, 2018 12:57 pm

triplus wrote:
Tue May 22, 2018 12:46 pm
Hi Pablo.

I can take a look at weekend. To see if anything obvious is at play. If i understand the issue correctly this only happens for the commands located on the View toolbar?
It only happens in file and view toolbars

Thanks!
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: [BUG?] Cropped icons

Postby triplus » Tue May 22, 2018 1:08 pm

pablogil wrote:
Tue May 22, 2018 12:57 pm
I mean, I have discovered that with IconThemes the problem is solved but I don't know why so I thought it was a nice option to ask triplus about it.
Problem solved. ;)
It only happens in file and view toolbars

Thanks!
Thanks for the feedback. Will take a look to see if any obvious clues emerge (at weekend).
User avatar
pablogil
Posts: 842
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: [BUG?] Cropped icons

Postby pablogil » Tue May 22, 2018 2:28 pm

Great!
So was it easy to solve?
If you anywhere have the pull request I will test it, thanks
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: [BUG?] Cropped icons

Postby triplus » Wed May 23, 2018 9:42 am

pablogil wrote:
Tue May 22, 2018 2:28 pm
Great!
So was it easy to solve?
If you anywhere have the pull request I will test it, thanks
Nah not solved yet! I was saying there i guess is a solution to the problem available. ;)

P.S. As for looking into the issue i won't have time to do that before weekend.
User avatar
pablogil
Posts: 842
Joined: Wed Nov 26, 2014 3:19 pm
Location: Badajoz (Spain)
Contact:

Re: [BUG?] Cropped icons

Postby pablogil » Wed May 23, 2018 12:14 pm

triplus wrote:
Wed May 23, 2018 9:42 am
pablogil wrote:
Tue May 22, 2018 2:28 pm
Great!
So was it easy to solve?
If you anywhere have the pull request I will test it, thanks
Nah not solved yet! I was saying there i guess is a solution to the problem available. ;)

P.S. As for looking into the issue i won't have time to do that before weekend.
Hahaha, sorry, sorry, I misunderstood you.
Yes, you are right, I solved it duplicating these icons into a new Theme and using it as default ;)

Don't worry, take your time, it was just an idea that you would know about how to solve the issue...
Thanks
Dark and Light stylesheets v2.0 to theme your FreeCAD UI, more information here
triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: [BUG?] Cropped icons

Postby triplus » Thu May 24, 2018 9:59 am

pablogil wrote:
Wed May 23, 2018 12:14 pm
Yes, you are right, I solved it duplicating these icons into a new Theme and using it as default ;)
Nice!