Defeaturing

[freecad-heini-1]

it seems that Cmake doesn't find OCC.
Contrary to what is written in my previous notes, it seems that I did install OCC

thx! finally I got it built!
Just a great addition and as easy as just selecting the faces to be defeatured!
Fillet and Chamfer easy to go away too
Looking forward to see it in the main branch

.. ping

PS @sgrogan do you think it would be possible to have a Windows daily build with OCC 7.3?
PPS my defeaturing tools will be still useful for stable and legacy FC builds

+1
And please a Ubuntu version.

[Chris_G]

i made a PR this morning.
But I don't know if it will be merged.
There is probably some mistakes in it, since the AppVeyor and Travis-CI builds failed.

[easyw-fc]

i made a PR this morning.
But I don't know if it will be merged.
There is probably some mistakes in it, since the AppVeyor and Travis-CI builds failed.

Code: Select all

/home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/TopoShape.cpp: In member function TopoDS_Shape Part::TopoShape::defeaturing(const std::vector<TopoDS_Shape>&) const’:
/home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/TopoShape.cpp:3424:5: error: BRepAlgoAPI_Defeaturing was not declared in this scope
     BRepAlgoAPI_Defeaturing defeat;

Probably it is because some functions may have changed within OCC7.3 release...
You may consider to add an ifdef depending on OCC version.

[Chris_G]

Probably it is because some functions may have changed within OCC7.3 release...
You may consider to add an ifdef depending on OCC version.

Thanks Maurice,
I think you're right, and this should fix.

[sgrogan]

I think you're right, and this should fix.

The Win 32 bit build timed out (The 64 bit version passed so I think it's not a problem)
The OSX build failed like all others, it looks like a QT related Homebrew problem.
FreeCAD actually does support default Ubuntu 14.04 libs (ie oce 0.15 = occt 6.7) I think we could make Travis use the OCCT from the PPA (currently occt 7.2)