Release of 0.18

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
Kunda1
Posts: 9213
Joined: Thu Jan 05, 2017 9:03 pm

Re: Release of 0.18

Postby Kunda1 » Fri Dec 28, 2018 3:52 pm

yorik wrote:
Fri Dec 28, 2018 1:05 pm
Also, like always, add 1) who made more than 5 git commits, 2) who made more than 500 wiki edits, 3) who has posted more than 500 times on this forum, 4) who has translated more than 5000 strings on crowdin. If someone wants to help me to collect this data (check who meets these criteria but is not in the About dialog yet), I'd be grateful! ;)
Do you want the github data to be from a certain date (like from the start date of the release of 0.17 till 0.18 or from the genesis of the project?
Alone you go faster. Together we go farther
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Fri Dec 28, 2018 6:22 pm

yorik wrote:
Fri Dec 28, 2018 1:05 pm
rebuilding a py2 version now to have a look. *EDIT* fixed in git commit 42e6650ac
I just compiled from master, I'm afraid this bug is not fixed.

The Start page is completely blank, and the following message is shown in the Report view.

Code: Select all

'ascii' codec can't decode byte 0xc3 in position 10: ordinal not in range(128)
The tab label is also using improper character encoding. Instead of "Page de démarrage", it reads "Page de dĀ©marrage".
FC018_StartPage_bug_01.png
FC018_StartPage_bug_01.png (5.53 KiB) Viewed 739 times
If I close the tab, switch to a different workbench, then switch back to the Start wb to try and get it back, I have this error message in the report view:

Code: Select all

Exception AttributeError: "'WebView' object has no attribute 'webPage'" in <bound method WebView.__del__ of <__main__.WebView object at 0x7fd55b845f10>> ignored
'ascii' codec can't decode byte 0xc3 in position 10: ordinal not in range(128)
If I switch FreeCAD's language to English, then close and restart FreeCAD, the StartPage is fine.

OS: Ubuntu 18.04.1 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15513 (Git)
Build type: Release
Branch: master
Hash: 42e6650ac0e6c6e53ebb7f2bb83a07a555ea51b0
Python version: 2.7.15rc1
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/Canada (fr_CA)
User avatar
Kunda1
Posts: 9213
Joined: Thu Jan 05, 2017 9:03 pm

Re: Release of 0.18

Postby Kunda1 » Fri Dec 28, 2018 8:01 pm

yorik wrote:
Fri Dec 28, 2018 1:05 pm

Also, for the release, we need to update the about dialog. I'll remove the piece about Roland, is that okay? I'm thinking of adding something next to his name below, not really sure what... Also, like always, add 1) who made more than 5 git commits,

Code: Select all

[beast@beast ]$ git shortlog --summary --numbered | sort -n -r
  4534	wmayer
  2285	Yorik van Havre
  1128	Bernd Hahnebach
   657	Markus Lampert
   592	Abdullah Tahiri
   495	jriegel
   441	Stefan Tröger
   439	WandererFan
   363	Przemo Firszt
   256	DeepSOIC
   247	jrheinlaender
   206	wwmayer
   199	sliptonic
   192	Sebastian Hoogen
   187	Eivind Kvedalen
   161	Zheng, Lei
   155	wandererfan
   150	logari81
   140	looooo
   124	Jose Luis Cercós pita
   124	Jose Luis Cercos Pita
   121	Alexander Golubev
   107	luz.paz
   103	yorikvanhavre
    89	Kurt Kremitzki
    87	Ian Rees
    76	Alexander Gryson
    73	blobfish
    66	kreso-t
    65	luzpaz
    57	Mateusz Skowroński
    52	triplus
    51	ml
    48	AjinkyaDahale
    44	Jose Luis Cercós Pita
    39	Jean-Marie Verdun
    37	jmaustpc
    34	Sergo
    34	Bruce B. Lacey
    33	tomate44
    32	Jose Luis Cercos-Pita
    31	Peter Lama
    30	vdwalts
    30	qingfengxia
    30	balazs-bamer
    28	Jonathan Wiedemann
    27	Shai Seger
    26	Unknown
    26	joha2
    24	paullee
    23	Lorenz Hüdepohl
    22	Priit Laes
    22	Keith Sloan
    19	pekkaroi
    19	Pablo Gil
    19	Markus Hovorka
    19	Mark Ganson TheMarkster
    18	Pekka Roivainen
    17	wood galaxy
    17	Kunda
    17	Johannes Reinhardt
    17	easyw
    15	makkemal
    15	Amritpal Singh
    14	sgrogan
    14	Sabin Iacob
    14	kgoao
    14	Johannes Obermayr
    14	Itai Nahshon
    14	hokieengr
    13	mdinger
    13	lorenz
    13	ickby
    13	Alex Gryson
    12	unknown
    12	mwganson
    12	markus
    12	J.L. Cercos-Pita
    12	Dan Falck
    11	tanderson
    11	Ryan Pavlik
    11	mrlukeparry
    11	George Shuklin
    10	SparkyCola
    10	Joachim Zettler
    10	Jan Rheinländer
     9	wood-galaxy
     9	msocorcim
     9	fandaL
     9	brad
     8	Stefan Troeger
     8	mkhizenz
     8	j-dowsett
     8	Fabio Rossi
     8	Cercos-Pita J.L
     7	vginkeo
     7	vejmarie
     7	Simon
     7	Michael Georg Hansen
     7	Gaël Écorchard
     7	Bruce Lacey
     6	hgutsche
     6	Clemens Weissbacher
     5	Wolfgang E. Sanyer
     5	Wilfried Hortschitz
     5	plgarcia
     5	Oliver Oxtoby
     5	maurerpe
     5	Marco Molteni
     5	Daniel Falck
     5	ageeye
Alone you go faster. Together we go farther
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
yorik
Site Admin
Posts: 12146
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Release of 0.18

Postby yorik » Fri Dec 28, 2018 9:01 pm

NormandC wrote:
Fri Dec 28, 2018 6:22 pm
I just compiled from master, I'm afraid this bug is not fixed.
The Start page is completely blank, and the following message is shown in the Report view.
This is strange, it works fine for me with both py2 and py3 versions... Can you put this in to the python console and see if any more precise error message comes up?

Code: Select all

from StartPage import StartPage
StartPage.handle()
About the start page tab wrongly encoded, that happens here I think https://github.com/FreeCAD/FreeCAD/blob ... ch.cpp#L73 but not sure exactly what needs to be done to solve it... Any idea, anyone?

@Kunda1, that's it. If I'm not abusing, if you could check that list against the current names, if any from your list is missing in the one below...

Code: Select all

Abdullah Tahiriyo (abdullah)
Ajinkya Dahale
Alexander Golubev (fat-zer)
Alexander Gryson (agryson)
Alexandre Prokoudine
Angelescu Constantin
ArminF
asakura
Balázs Bámer
Bartlomiej Niemiec
bejant
Bernd Hahnebach (bernd)
blobfish (tanderson69)
bluecd
Brad Collette (sliptonic)
Bruce Lacey (bblacey)
Bruno Gonçalves Pirajá
Christophe Grellier (tomate44)
Daniel Falck (danielfalck)
Дмитрий Сидоров 
cblt2l
cox
easyw-fc
Ediloren
Eduardo Magdalena
Eivind Kvedalen (eivindkvedalen)
Ettore Atalan
fandaL
Федір
Gerhard Scheepers
hanhsuan
hamish2014
heini-1
Hervé Blorec
hicarl
Honza32
HoWil
htsubota
Ian Rees
Igor
Isaac Ayala
Jan Rheinlaender (jrheinlaender)
javierMG
Jean-Marie Verdun (vejmarie)
Jean-Pierre Granet
Jee-Bee
Jiyong Choi
jmaustpc
joha2
Jodbe
Johannes Obermayr
Jonathan Wiedemann (rockn/woodgalaxy)
Jose Luis Cercos Pita (sanguinariojoe)
jreinhardt
Jürgen Riegel (jriegel)
Keith Sloan
kgoao
kunguz
Kurt Kremitzki (kkremitzki)
Lars
lhuedepohl
logari81
looooo
Luke Parry (mrlukeparry)
luzpaz (Kunda1)
Марко Пејовић
Markus Hovorka (drhooves)
Markus Lampert (mlampert)
Marosh
Masaya Ootsuki
Mateusz Skowroński (f3nix)
Mattis M
mdinger
Meme2704
Michael Hansen
Michael Hindley (makkemal)
microelly2
Miguel Morais
Николай Матвеев
Nicu Tofan
nikoss
Normand Chamberland (NormandC)
Onesz
Pablo Gil
Pasi Kukkola
Paul Lee
Peta T
Peter Hageman
Peter Klofutar
Peter Lama (peterl94)
piffpoof
pinkpony
Priit Laes
pperisin
Prezmo Firszt (PrzemoF)
Qingfeng Xia
quick61
rako
Raulshc
realthunder
Renato Rebelo
Renato Rivoira (renatorivo)
Rentlau
Roland Frank (r-frank)
Sabin Iacob
Saso Badovinac (saso)
sema
Sergo Pogosyan (usakhelo)
sgrogan
Shai Seger (shaise)
shoogen
Starofrainnight
Stefan Tröger (ickby)
stoflap
Thomas Schrader
Timo Seppola
totyg
triplus
trzyha
ulrich1a
Victor Radulescu
Victor Titov (DeepSOIC)
Vilfredo
WandererFan
wbrwbr2011
Werner Mayer (wmayer)
Wurstwasser
yang12
Yorik van Havre (yorik)
Zdeněk Havlík
Also if anyone sees errors in the list, names wrongly written, etc... Tell me!
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Fri Dec 28, 2018 10:07 pm

@abdullah

Seems there's a regression with Sketcher grid size setting not being taken into account: https://forum.freecadweb.org/viewtopic.php?f=3&t=33055

yorik wrote:
Fri Dec 28, 2018 9:01 pm
Can you put this in to the python console and see if any more precise error message comes up?

Code: Select all

>>> from StartPage import StartPage
>>> StartPage.handle()
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/home/normand2/compilation/FreeCAD/freecad-build/Mod/Start/StartPage/StartPage.py", line 333, in handle
    SECTION_EXAMPLES += buildCard(filename,method="LoadExample.py?filename=")
  File "/home/normand2/compilation/FreeCAD/freecad-build/Mod/Start/StartPage/StartPage.py", line 205, in buildCard
    result += '<a href="'+method+arg+'" title="'+infostring+'">'
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 10: ordinal not in range(128)
wmayer
Site Admin
Posts: 16864
Joined: Thu Feb 19, 2009 10:32 am

Re: Release of 0.18

Postby wmayer » Fri Dec 28, 2018 10:15 pm

Removing these lines from StartPage.py seems to fix the problem:

Code: Select all

        if sys.version_info.major < 3:
            SECTION_RECENTFILES = SECTION_RECENTFILES.decode("utf8")

    if sys.version_info.major < 3:
        SECTION_EXAMPLES = SECTION_EXAMPLES.decode("utf8")

    if sys.version_info.major < 3:
        SECTION_CUSTOM = SECTION_CUSTOM.decode("utf8")

                if sys.version_info.major < 3:
                    ALTCSS = ALTCSS.decode("utf8")
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Fri Dec 28, 2018 10:34 pm

wmayer wrote:
Fri Dec 28, 2018 10:15 pm
Removing these lines from StartPage.py seems to fix the problem:
Not for me. Are you trying this with language set to French? As I said, there is no issue if FreeCAD's language is set to English.

Edit: the affected languages are:

Čeština
中文 (first Chinese option)
Français
Galego
Deutsch
Magyar
‎日本語 (Japanese)
Polski
Português europeu
Português do Brasil
Română
русский (Russian)
Slovenščina
Español de España
Svenska
Türkçe
український
Valencian
PAT64
Posts: 69
Joined: Wed May 25, 2016 2:53 pm
Location: Pyrénées Atlantiques

Re: Release of 0.18

Postby PAT64 » Sat Dec 29, 2018 3:05 am

0.18 15496

Hello,
I am under windows 10, I had the version 0.18 15380 which worked well, I saw this new version (15496) and I have more page start (start page), and the windows that open style preference changes format and can not read the bottom of the page.Unfortunately I deleted the previous version; or I get it back while waiting for a corrected version. Thank you to all good evening and end of year celebrations.
Despite this little "bug" congratulations to all the contributors of this wonderful project that is Freecad, thank you and good luck.
Thank you for your answer but it's the same version * 64 and 86.
When freecad opens I have this message that appears in red at the bottom of the screen and that stays a fraction of a second
message: 'ascii' codec can not decode byte 0xc3 in position 34 ordinal not in range (128) ..
If it helps you, good luck and thank you day
wmayer
Site Admin
Posts: 16864
Joined: Thu Feb 19, 2009 10:32 am

Re: Release of 0.18

Postby wmayer » Sat Dec 29, 2018 12:06 pm

Not for me. Are you trying this with language set to French? As I said, there is no issue if FreeCAD's language is set to English.
No, but it's set to German (Deutsch). After removing these lines it worked for me.
mumme
Posts: 35
Joined: Sun Jun 21, 2015 4:52 pm

Re: Release of 0.18

Postby mumme » Sat Dec 29, 2018 12:17 pm

NormandC wrote:
Fri Dec 28, 2018 10:34 pm
wmayer wrote:
Fri Dec 28, 2018 10:15 pm
Removing these lines from StartPage.py seems to fix the problem:
Not for me. Are you trying this with language set to French? As I said, there is no issue if FreeCAD's language is set to English.
I got it to work in swedish with this

Can you please try? (must change in [builddir]/src/Mod/Start/StartPage/StartPage.py or do a complete rebuild)

Code: Select all

diff --git a/src/Mod/Start/StartPage/StartPage.py b/src/Mod/Start/StartPage/StartPage.py
index 8e1bf2c05..f5cb65798 100644
--- a/src/Mod/Start/StartPage/StartPage.py
+++ b/src/Mod/Start/StartPage/StartPage.py
@@ -192,6 +192,9 @@ def buildCard(filename,method,arg=None):
         basename = os.path.basename(filename)
         if not arg:
             arg = basename
+        if sys.version_info.major < 3:
+            arg = str(arg)
+            basename = str(basename)
         finfo = getInfo(filename)
         if finfo:
             image = finfo[0]
@@ -252,6 +255,7 @@ def handle():
     HTML = HTML.replace("JS",JS)
     HTML = HTML.replace("CSS",CSS)
 
+
     # get the stylesheet if we are using one
 
     if FreeCAD.ParamGet("User parameter:BaseApp/Preferences/Mod/Start").GetBool("UseStyleSheet",False):
@@ -359,8 +363,8 @@ def handle():
             filename = FreeCAD.getResourceDir()+"examples"+os.sep+basename
             SECTION_EXAMPLES += buildCard(filename,method="LoadExample.py?filename=")
         SECTION_EXAMPLES += "</ul>"
-    if sys.version_info.major < 3:
-        SECTION_EXAMPLES = SECTION_EXAMPLES.decode("utf8")
+    #if sys.version_info.major < 3:
+        #SECTION_EXAMPLES = str(SECTION_EXAMPLES.decode("utf8"))
     HTML = HTML.replace("SECTION_EXAMPLES",SECTION_EXAMPLES)
 
     # build SECTION_CUSTOM
@@ -376,8 +380,8 @@ def handle():
             filename = os.path.join(cfolder,basename)
             SECTION_CUSTOM += buildCard(filename,method="LoadCustom.py?filename=")
         SECTION_CUSTOM += "</ul>"
-    if sys.version_info.major < 3:
-        SECTION_CUSTOM = SECTION_CUSTOM.decode("utf8")
+   # if sys.version_info.major < 3:
+    #    SECTION_CUSTOM = SECTION_CUSTOM.decode("utf8")
     HTML = HTML.replace("SECTION_CUSTOM",SECTION_CUSTOM)
 
     # build UL_WORKBENCHES
@@ -422,6 +426,8 @@ def handle():
         UL_WORKBENCHES += '<a href="https://www.freecadweb.org/wiki/'+wn+'_Workbench">'+wn.replace("ReverseEngineering","ReverseEng")+'</a>'
         UL_WORKBENCHES += '</li>'
     UL_WORKBENCHES += '</ul>'
+    if sys.version_info.major < 3:
+        UL_WORKBENCHES = str(UL_WORKBENCHES)
     HTML = HTML.replace("UL_WORKBENCHES",UL_WORKBENCHES)
 
     # Detect additional addons that are not a workbench