Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
Kunda1
Posts: 5949
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Postby Kunda1 » Sat Jun 22, 2019 1:44 pm

Russ4262 wrote:
Sat Jun 22, 2019 12:28 pm
commit 332bfb5052a2f7d45c0683866eba79bf2807d22f
Hey @Russ4262
FYI, if you put the hash within the commit bbcode tags it will automagically link to said commit. You don't actually need to use the whole hash number (8 chars should be enough) :)

Code: Select all

[commit]332bfb50[/commit]
git commit 332bfb50
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
wmayer
Site Admin
Posts: 15000
Joined: Thu Feb 19, 2009 10:32 am

Re: Back port commits to 0.18 branch

Postby wmayer » Mon Jun 24, 2019 12:35 pm

User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Back port commits to 0.18 branch

Postby uwestoehr » Wed Jun 26, 2019 6:59 pm

There are 2 commits to be backported for the sketcher:
abdullah wrote:
Wed Jun 26, 2019 3:40 pm
Carbon copy related that should be clean to backport:
git commit e632e9feb8a9dd56d5a879f2afef636cc159095e
git commit b9417938c487d82ae0b4132850b172d2108cd096
I don't know how backporting is handled. Could anyone please tell abdullah that he can do the backport?
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Back port commits to 0.18 branch

Postby jmaustpc » Thu Jun 27, 2019 12:59 am

uwestoehr wrote:
Wed Jun 26, 2019 6:59 pm
There are 2 commits to be backported for the sketcher:
abdullah wrote:
Wed Jun 26, 2019 3:40 pm
Carbon copy related that should be clean to backport:
e632e9feb8a9dd56d5a879f2afef636cc159095e
b9417938c487d82ae0b4132850b172d2108cd096
I don't know how backporting is handled. Could anyone please tell abdullah that he can do the backport?
uwestoehr is referring to this topic from Abdullah,
https://forum.freecadweb.org/viewtopic. ... 80#p317083

which is about "Sketcher Carbon Copy"

Jim
wmayer
Site Admin
Posts: 15000
Joined: Thu Feb 19, 2009 10:32 am

Re: Back port commits to 0.18 branch

Postby wmayer » Fri Jun 28, 2019 8:49 am

Done.
User avatar
Russ4262
Posts: 224
Joined: Sat Jun 30, 2018 3:22 pm

Re: Back port commits to 0.18 branch

Postby Russ4262 » Fri Jun 28, 2019 1:00 pm

wmayer wrote:
Sat Jun 22, 2019 12:40 pm
Done!
Than you, Sir!
Have a great day.
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Back port commits to 0.18 branch

Postby kkremitzki » Tue Jul 16, 2019 5:37 pm

Should we tag 0.18.3 yet?
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
uwestoehr
Posts: 794
Joined: Sun Jan 27, 2019 3:21 am

Re: Back port commits to 0.18 branch

Postby uwestoehr » Tue Jul 16, 2019 5:56 pm

kkremitzki wrote:
Tue Jul 16, 2019 5:37 pm
Should we tag 0.18.3 yet?
I vote for yes.

I also have 2 proposals:
* to release every 2 months a point release (bugfixes only)
* we nominate someone as "backport manager".

Why a 2 month rhythm?: There were even crash bugs fixed but also other already fixed bugs are annoying for users and since there is already a fix, we can deliver it to the users.

Why a "backport manager"?: To consequently backport all bugfixes there should be somebody, if possible a developer with commit rights. He checks once a week the commits on what has been fixed. If something could be backported he nominates this in this forum section. If necessary this can be discussed and the bugfix authors can do the backport, or he does the backport directly in straight forward cases.
looo
Posts: 2965
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Postby looo » Tue Jul 16, 2019 7:53 pm

kkremitzki wrote:
Tue Jul 16, 2019 5:37 pm
Should we tag 0.18.3 yet?
I am waiting for 0.18.3 since quite some time: https://github.com/conda-forge/freecad- ... ck/pull/26
please help with my conda-packaging efforts: https://liberapay.com/looooo/
User avatar
sgrogan
Posts: 5475
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Postby sgrogan » Tue Jul 16, 2019 9:01 pm

looo wrote:
Tue Jul 16, 2019 7:53 pm
I am waiting for 0.18.3 since quite some time: https://github.com/conda-forge/freecad- ... ck/pull/26
@looo and @kkremitzki, can you see this https://github.com/FreeCAD/FreeCAD/rele ... 22eec954f2?

You need to be logged on to Github and may need repo rights.
I created a tag, but left it as draft. We were under construction last time for too long, mostly due to me. I will try to push some assets as draft and see if it's OK. If we can fill up the assets before making public that would be good.