Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

looo wrote: Fri Jul 19, 2019 7:50 pm Thanks, I updated the 0.18 package which is available from conda-forge. Now the question is if we should go with the old (qt5.6) deps or if we should switch to new (qt5.9) deps. On osx qt5.9 is working better.
For win I still have problems with self compiled QT5.9 (because of the boost 1.7) so I used QT5.6
I would suggest using QT5.9. I'll update it when I get it working (I did see your pull request test)

I could also package directly from your win QT5.9 Conda Win build in a new conda env. This might be a good exercise, after this it should be easy to add it to the Travis weekly Conda builds.
"fight the good fight"
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

To me issue #4017 seems worth to be backported.

I have again a proposal 8-) :
I notice that bugs are immediately closed when the fix is in master. I think it would be good to keep them open until the fix was released or at least until it is also backported.
Users affected by a bug might search if it is a known one. If the bug report is closed you won't find it since you search if course for open bugs. So the status "closed" implies it is fixed while for the majority of users (using 0.18.x) it is not - yet.
wandererfan wrote: Thu Jul 18, 2019 2:06 pm -
Last edited by uwestoehr on Sat Jul 20, 2019 12:35 am, edited 1 time in total.
User avatar
wandererfan
Veteran
Posts: 6309
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Back port commits to 0.18 branch

Post by wandererfan »

uwestoehr wrote: Fri Jul 19, 2019 11:33 pm To me issue #4017 seems worth to be backported.
Sounds reasonable to me. I'll see if I can figure out how to do it.
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

sgrogan wrote: Fri Jul 19, 2019 10:10 pm
looo wrote: Fri Jul 19, 2019 7:50 pm Thanks, I updated the 0.18 package which is available from conda-forge. Now the question is if we should go with the old (qt5.6) deps or if we should switch to new (qt5.9) deps. On osx qt5.9 is working better.
For win I still have problems with self compiled QT5.9 (because of the boost 1.7) so I used QT5.6
I would suggest using QT5.9. I'll update it when I get it working (I did see your pull request test)

Yes, moving 0.18.3 to qt5.9 looks quite obvious to me. But as said I need come help from @triplus as I have no idea about the upload-scripts.
I could also package directly from your win QT5.9 Conda Win build in a new conda env. This might be a good exercise, after this it should be easy to add it to the Travis weekly Conda builds.
Yes, this would be nice addition.
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

looo wrote: Sat Jul 20, 2019 9:01 am Yes, this would be nice addition.
From which channel do I get the 0.18.3 build?
looo wrote: Sat Jul 20, 2019 9:01 am Yes, moving 0.18.3 to qt5.9 looks quite obvious to me. But as said I need come help from @triplus as I have no idea about the upload-scripts.
When I am successful with Win I will look at this, I need to understand for Win as above.
"fight the good fight"
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

wandererfan wrote: Sat Jul 20, 2019 12:28 am Sounds reasonable to me. I'll see if I can figure out how to do it.
Unfortunately we have published the 0.18.3 tag, so this will be part of 0.18.4.
"fight the good fight"
User avatar
kkremitzki
Veteran
Posts: 2515
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: Back port commits to 0.18 branch

Post by kkremitzki »

The stable PPA is updated btw.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

sgrogan wrote: Sat Jul 20, 2019 6:55 pm
looo wrote: Sat Jul 20, 2019 9:01 am Yes, this would be nice addition.
From which channel do I get the 0.18.3 build?
Everything should be in conda-forge:

Code: Select all

conda create -n freecad-0.18.3 freecad=0.18.3 -c conda-forge
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

looo wrote: Sun Jul 21, 2019 6:33 am Everything should be in conda-forge:
Thanks, should the WebGui work?
"fight the good fight"
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

sgrogan wrote: Sun Jul 21, 2019 6:22 pm Thanks, should the WebGui work?
You are right. Seems like qtwebengine is not supported in 0.18.3. In 0.19 it's automatically detected.

edit: this one is needed: https://github.com/FreeCAD/FreeCAD/comm ... 92a53c7291
Post Reply