Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
bernd
Posts: 8216
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Back port commits to 0.18 branch

Postby bernd » Mon Sep 02, 2019 4:33 pm

Syres wrote:
Sun Aug 25, 2019 8:12 am
Not sure if 0.18.4 is being considered but if so, this maybe relevant https://forum.freecadweb.org/viewtopic. ... 20#p329120

EDIT: The commit is https://github.com/FreeCAD/FreeCAD/commit/6a8f6e2a
is in 0.18 branch already ... https://github.com/FreeCAD/FreeCAD/commit/1e9f9fa
User avatar
Kunda1
Posts: 5149
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Postby Kunda1 » Tue Sep 03, 2019 9:03 pm

Aesthetic Proposal - Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)
Similiar to what we did for 0.19 in git commit ba6a6d63ee9c984
I think this proposal is merited since once we consider the final version 0.18 we leave it that way for posterity. This fix makes it so that when people create youtube videos or screencasts that said multimedia can show how the StartWB was intended to be shown (with all the example files displaying their legit screenshots). See the thread to show the difference in the UI.

Edit: further justification:
A seemingly insignificant cosmetic change but for slow-poke distros like ubuntu/debian, 0.18.x will be around for a while and people will produce videos and content and I think it makes sense from a aesthetic and Public Relations point of view to tweek this.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
kkremitzki
Posts: 1671
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Back port commits to 0.18 branch

Postby kkremitzki » Tue Sep 03, 2019 9:04 pm

+1, IMO it is more of a bug fix than an added feature so it seems OK to backport.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
triplus
Posts: 8605
Joined: Mon Dec 12, 2011 4:45 pm

Re: Back port commits to 0.18 branch

Postby triplus » Tue Sep 03, 2019 9:16 pm

Adding the thumbnail is adding a new feature. The code still works just fine, if the thumbnail isn't there.

P.S. Therefore sorry, this isn't about fixing any bug. Said that, i don't really care whatever happens next, and don't plan to invest any more time in it. ;)
chrisb
Posts: 17519
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.18 branch

Postby chrisb » Tue Sep 03, 2019 9:20 pm

I don't know how complicated backports are, but I'm in general against backporting minor issues. The benefit is low and there is always some danger that another issue is introduced - perhaps an even more serious one.

Perhaps we should discuss this from a more general view. My opinion: backports for crash, destroyed models, complicated workaround needed. No backports for cosmetic changes.

We usually have a very stable developer version which very well can be recommended for daily work. The Big Link Merge makes the situation currently different, but I'm confident, that this will settle soon.
User avatar
Kunda1
Posts: 5149
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Postby Kunda1 » Tue Sep 03, 2019 10:15 pm

Kunda1 wrote:
Tue Sep 03, 2019 9:03 pm
Edit: further justification:
A seemingly insignificant cosmetic change but for slow-poke distros like ubuntu/debian, 0.18.x will be around for a while and people will produce videos and content and I think it makes sense from a aesthetic and Public Relations point of view to tweek this.
Case in point: see how long older version of FC are still around
Image

I also agree with @kkremitzki that this is more a bugfix than a feature since this should of been working but it wasn't. It's a regression actually.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
triplus
Posts: 8605
Joined: Mon Dec 12, 2011 4:45 pm

Re: Back port commits to 0.18 branch

Postby triplus » Tue Sep 03, 2019 10:25 pm

Yeah, and lets add App::Link too. ;)
triplus
Posts: 8605
Joined: Mon Dec 12, 2011 4:45 pm

Re: Back port commits to 0.18 branch

Postby triplus » Wed Sep 11, 2019 10:19 am

After review and hopefully merge happens:

https://github.com/FreeCAD/FreeCAD/pull/2520

And once the proposed change will get included in FreeCAD 0.19 AppImage. I will test if everything works as expected. If yes, this PR should be back ported and to be included in FreeCAD 0.18.4 (AppImage).