Agreed.
Back port commits to 0.18 branch
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
- kkremitzki
- Veteran
- Posts: 2515
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: Back port commits to 0.18 branch
If looo and triplus agree I can create the tag.
"fight the good fight"
Re: Back port commits to 0.18 branch
We have only just managed to produce 0.18.1 packages, we don't want to be making these minor releases too often, we are not creating a rolling release, or at least we haven't in the past. The PPA release 0.18.1 package is still not perfect on Kubuntu18.04, we still have the issue of FreeCAD defaulting to open in the wrong directory.
Its one of the purposes of the daily PPA to have and test the latest code. We have in the past released point releases where there were critical/embarrassing/commonly found bugs etc.
I am not saying "don't do a point release", but I just wonder if we would be rushing a bit to do it yet? Are any of the bugs bad enough or are there enough bugs, to warrant a new release? If the bugs are not all that serious, perhaps we should wait another month or so and see if we get more bug fix commits first?
Jim
Re: Back port commits to 0.18 branch
The majority of fixes in the point releases were critical issues so it was fine to back port them. And in the past for most releases we back ported several bug fixes after the first weeks too -- maybe this time a bit more than usually but that's still OK as long as we really fix critical or major issues only.I am not saying "don't do a point release", but I just wonder if we would be rushing a bit to do it yet? Are any of the bugs bad enough or are there enough bugs, to warrant a new release? If the bugs are not all that serious, perhaps we should wait another month or so and see if we get more bug fix commits first?
Re: Back port commits to 0.18 branch
Would it be possible to back port also this PR 2088yorik wrote: ↑Thu May 02, 2019 7:13 pm git commit ebca0c983 - Backported a fix for non-working Draft DXF importer - https://forum.freecadweb.org/viewtopic. ... 79#p305379
It is fixing Import/export '.stpz' file format
EDIT:
hold on please... I found an other issue when exporting... I'll make a PR asap
EDIT2:
here the final PR 2134 along with this PR 2088
Re: Back port commits to 0.18 branch
That is OK with me. After @looo will update the stable package on Conda, Travis should deploy macOS and Linux FreeCAD 0.18.2 builds on GitHub releases page. What needs to get done on Travis is bumping DEPLOY_RELEASE_STABLE="0.18.2". Or binaries (AppImage and dmg ones) from 0.18.1 will get overwritten with FreeCAD 0.18.2. Note that currently we still deploy stable macOS and AppImage binaries on a daily basis, due to sorting out some outstanding issues.
P.S. @looo don't forget about correct version info.
Re: Back port commits to 0.18 branch
git commit 1fb7ed43c - Backported a fix in Arch roofs