Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
kkremitzki
Posts: 2195
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Back port commits to 0.18 branch

Postby kkremitzki » Thu May 02, 2019 8:59 pm

sgrogan wrote:
Thu May 02, 2019 8:43 pm
I think we should do 0.18.2
Thoughts?
Agreed.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
sgrogan
Posts: 6205
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Postby sgrogan » Thu May 02, 2019 9:02 pm

kkremitzki wrote:
Thu May 02, 2019 8:59 pm
Agreed.
If looo and triplus agree I can create the tag.
"fight the good fight"
jmaustpc
Posts: 10512
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Back port commits to 0.18 branch

Postby jmaustpc » Fri May 03, 2019 5:07 am

sgrogan wrote:
Thu May 02, 2019 8:43 pm
I think we should do 0.18.2
Thoughts?
We have only just managed to produce 0.18.1 packages, we don't want to be making these minor releases too often, we are not creating a rolling release, or at least we haven't in the past. The PPA release 0.18.1 package is still not perfect on Kubuntu18.04, we still have the issue of FreeCAD defaulting to open in the wrong directory.

Its one of the purposes of the daily PPA to have and test the latest code. We have in the past released point releases where there were critical/embarrassing/commonly found bugs etc.

I am not saying "don't do a point release", but I just wonder if we would be rushing a bit to do it yet? Are any of the bugs bad enough or are there enough bugs, to warrant a new release? If the bugs are not all that serious, perhaps we should wait another month or so and see if we get more bug fix commits first?

Jim
wmayer
Site Admin
Posts: 16841
Joined: Thu Feb 19, 2009 10:32 am

Re: Back port commits to 0.18 branch

Postby wmayer » Fri May 03, 2019 8:50 am

I am not saying "don't do a point release", but I just wonder if we would be rushing a bit to do it yet? Are any of the bugs bad enough or are there enough bugs, to warrant a new release? If the bugs are not all that serious, perhaps we should wait another month or so and see if we get more bug fix commits first?
The majority of fixes in the point releases were critical issues so it was fine to back port them. And in the past for most releases we back ported several bug fixes after the first weeks too -- maybe this time a bit more than usually but that's still OK as long as we really fix critical or major issues only.
User avatar
easyw-fc
Posts: 2927
Joined: Thu Jul 09, 2015 9:34 am

Re: Back port commits to 0.18 branch

Postby easyw-fc » Fri May 03, 2019 8:53 am

yorik wrote:
Thu May 02, 2019 7:13 pm
git commit ebca0c983 - Backported a fix for non-working Draft DXF importer - https://forum.freecadweb.org/viewtopic. ... 79#p305379
Would it be possible to back port also this PR 2088
It is fixing Import/export '.stpz' file format
EDIT:
hold on please... I found an other issue when exporting... I'll make a PR asap
EDIT2:
here the final PR 2134 along with this PR 2088
triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: Back port commits to 0.18 branch

Postby triplus » Mon May 06, 2019 9:23 pm

sgrogan wrote:
Thu May 02, 2019 9:02 pm
kkremitzki wrote:
Thu May 02, 2019 8:59 pm
Agreed.
If looo and triplus agree I can create the tag.
That is OK with me. After @looo will update the stable package on Conda, Travis should deploy macOS and Linux FreeCAD 0.18.2 builds on GitHub releases page. What needs to get done on Travis is bumping DEPLOY_RELEASE_STABLE="0.18.2". Or binaries (AppImage and dmg ones) from 0.18.1 will get overwritten with FreeCAD 0.18.2. Note that currently we still deploy stable macOS and AppImage binaries on a daily basis, due to sorting out some outstanding issues.

P.S. @looo don't forget about correct version info.
User avatar
yorik
Site Admin
Posts: 12145
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Back port commits to 0.18 branch

Postby yorik » Wed May 08, 2019 1:51 am

git commit 1fb7ed43c - Backported a fix in Arch roofs
User avatar
looo
Posts: 3485
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Postby looo » Wed May 08, 2019 7:55 am

triplus wrote:
Mon May 06, 2019 9:23 pm
P.S. @looo don't forget about correct version info.
Git is now used for all freecad-feedstocks to get sources. So this shouldn't be a problem.
triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: Back port commits to 0.18 branch

Postby triplus » Wed May 08, 2019 10:26 am

looo wrote:
Wed May 08, 2019 7:55 am
Git is now used for all freecad-feedstocks to get sources. So this shouldn't be a problem.
Great!
User avatar
easyw-fc
Posts: 2927
Joined: Thu Jul 09, 2015 9:34 am

Re: Back port commits to 0.18 branch

Postby easyw-fc » Wed May 08, 2019 1:12 pm

PR 2152
backporting of:
PR 2134 and PR 2088

PR 2153
backporting of
PR 2137