Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Back port commits to 0.18 branch

Postby jmaustpc » Wed May 08, 2019 2:24 pm

wmayer wrote:
Fri May 03, 2019 8:50 am
I am not saying "don't do a point release", but I just wonder if we would be rushing a bit to do it yet? Are any of the bugs bad enough or are there enough bugs, to warrant a new release? If the bugs are not all that serious, perhaps we should wait another month or so and see if we get more bug fix commits first?
The majority of fixes in the point releases were critical issues so it was fine to back port them. And in the past for most releases we back ported several bug fixes after the first weeks too -- maybe this time a bit more than usually but that's still OK as long as we really fix critical or major issues only.
OK, no worries.


I wonder about this bug, issue #3943, its about auto-hiding of the solid when entering its sketch in PartDesign, if you turn that off (toggle its property) it still hides the solid but when you close sketch edit mode the solid remains hidden. As far as I know the bug has not been addressed yet.
User avatar
sgrogan
Posts: 5331
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Postby sgrogan » Wed May 08, 2019 9:02 pm

looo wrote:
Wed May 08, 2019 7:55 am
Git is now used for all freecad-feedstocks to get sources. So this shouldn't be a problem.
Great, thanks for the response. I'll wait a couple of days for wmayer and yorik to respond to some of the other requests.

I just don't want to let stuff that is backported wait too long. If the integrators make the effort to backport stuff we should use it. I agree with wmayer that only important stuff should be backported (I'm sure this will mean different things to different people). I think we are providing regular developer builds for 0.19 so the other stuff can be tested there.
User avatar
bernd
Posts: 8332
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Back port commits to 0.18 branch

Postby bernd » Sat May 11, 2019 8:13 am

Python 3 issue ... git commit cd74f2e92 without this BOLTS addon does not run on FreeCAD with Python 3 and thus not on 0.18.x
wmayer
Site Admin
Posts: 14782
Joined: Thu Feb 19, 2009 10:32 am

Re: Back port commits to 0.18 branch

Postby wmayer » Sat May 11, 2019 9:06 am

User avatar
sgrogan
Posts: 5331
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Postby sgrogan » Sat May 11, 2019 2:07 pm

wmayer wrote:
Sat May 11, 2019 9:06 am
https://github.com/FreeCAD/FreeCAD/comm ... eeCAD-0-18
Thank You!
I have created the 0.18.2 tag and release page. https://github.com/FreeCAD/FreeCAD/releases/tag/0.18.2
User avatar
Russ4262
Posts: 222
Joined: Sat Jun 30, 2018 3:22 pm

Re: Back port commits to 0.18 branch

Postby Russ4262 » Mon May 13, 2019 4:32 am

Evening Gents.

May I suggest a recent PR, #2157: added try,except for OpenCamLib test on Path WB, be considered for backporting. Some users are locked out of the PathWB due to dependency issues, related to the OpenCamLib availability, hard coded into the PathWB. I believe this PR has eliminated the issue and is worthy of consideration for those interested in the Stable 0.18 release with a desire to harness the features in the PathWB without possible frustration from this problem.

Only a request, Sirs.

Thanks,
Russell
wmayer
Site Admin
Posts: 14782
Joined: Thu Feb 19, 2009 10:32 am

Re: Back port commits to 0.18 branch

Postby wmayer » Mon May 13, 2019 8:20 am

The OpenCamLib shouldn't be an issue for v0.18 because it was added to v0.19 only. So nothing to do for v0.18 unless I missed something?
User avatar
Russ4262
Posts: 222
Joined: Sat Jun 30, 2018 3:22 pm

Re: Back port commits to 0.18 branch

Postby Russ4262 » Mon May 13, 2019 2:59 pm

@WMayer,
Nothing missed, Sir. I was of the mindset this (the OCL dependency for PathWB) was a pre-existing situation. It is not. I downloaded FreeCAD_0.18.16110_LP_11.11_PY2QT4-WinVS2013_x64_portable.7z and the PathWB is accessible without ocl.

Great awareness, Sir.

Thanks,
Russell
User avatar
easyw-fc
Posts: 2627
Joined: Thu Jul 09, 2015 9:34 am

Re: Back port commits to 0.18 branch

Postby easyw-fc » Thu May 23, 2019 6:16 pm

sgrogan wrote:
Sat May 11, 2019 2:07 pm
Thank You!
I have created the 0.18.2 tag and release page. https://github.com/FreeCAD/FreeCAD/releases/tag/0.18.2
Any news on 0.18.2 builds?
I cannot find anything on gh release page...
looo
Posts: 2821
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Postby looo » Thu May 23, 2019 6:36 pm

easyw-fc wrote:
Thu May 23, 2019 6:16 pm
Any news on 0.18.2 builds?
I cannot find anything on gh release page...
linux and osx should come soon. I pinned 0.18.1, that's why it wasn't updated:
https://github.com/FreeCAD/FreeCAD-AppI ... 8fe2c27f00