Appveyor is timing out

[abdullah]

I think this is the moment when I go out of the pond Archimides style crying aloud "Eureka":

https://travis-ci.org/FreeCAD/FreeCAD/jobs/527419405

If this ends ok, which I think it should.

The problem:
1. We have secrets in our Travis script.
2. The securing mechanism interferes somehow with msbuild.
3. This does not happen during PR, because PR are protected from accessing secrets.

Work-around - use "filter-secrets: false":
https://github.com/FreeCAD/FreeCAD/comm ... 364b04ef90

Isn't this a security hazard?
1. The flag "filter-secrets: false" is only set for windows builds.
2. No part of the windows execution path shows the content of the variables.

I do not see the security hazard, but please take a closer look and let me know if you see any concerns.

[abdullah]

Well, it seems that we have now travis windows builds running in 50 minutes with the help of clcache:

https://travis-ci.org/FreeCAD/FreeCAD/b ... tification

The tests are not working well yet (some appear not to run, but still they are reported as passing), but that thankfully can be tested in a branch with a PR.

[wmayer]

Well, it seems that we have now travis windows builds running in 50 minutes with the help of clcache:

https://travis-ci.org/FreeCAD/FreeCAD/b ... tification

The tests are not working well yet (some appear not to run, but still they are reported as passing), but that thankfully can be tested in a branch with a PR.

Thanks for your hard work to get it running.

[abdullah]

Well, it seems that we have now travis windows builds running in 50 minutes with the help of clcache:

https://travis-ci.org/FreeCAD/FreeCAD/b ... tification

The tests are not working well yet (some appear not to run, but still they are reported as passing), but that thankfully can be tested in a branch with a PR.

Thanks for your hard work to get it running.

Thanks for bearing with me

[abdullah]

PCH Part_GUI:
https://github.com/FreeCAD/FreeCAD/pull/2135

I am currently doing PCH for the Path WB.

[abdullah]

... ping ...

One question:
src/Mod/Path/libarea/Area.h

should qualify as a 3rd party library, shouldn't it?

[wmayer]

... ping ...

One question:
src/Mod/Path/libarea/Area.h

should qualify as a 3rd party library, shouldn't it?

That's a corner case. But when it changes then only very rarely. So it can be considered as 3rd party lib.

[apeltauer]

Well, it seems that we have now travis windows builds running in 50 minutes with the help of clcache:

https://travis-ci.org/FreeCAD/FreeCAD/b ... tification

The tests are not working well yet (some appear not to run, but still they are reported as passing), but that thankfully can be tested in a branch with a PR.

Thanks for your hard work to get it running.

Good work....

[abdullah]

... ping ...

One question:
src/Mod/Path/libarea/Area.h

should qualify as a 3rd party library, shouldn't it?

That's a corner case. But when it changes then only very rarely. So it can be considered as 3rd party lib.

I have added it:
https://github.com/FreeCAD/FreeCAD/pull/2136

I am not sure how it will work, because I had to put a second #ifdef block or it would not compile:
https://github.com/FreeCAD/FreeCAD/pull ... b81f16bd2f

Current PCH Status:
1. Part APP: In master - PCH Enabled
2. Part GUI: PR - PCH Not enabled in CMakeList.txt
3. PartDesign APP: In master - PCH Enabled
4. PartDesign GUI: In master - PCH Not enabled in CMakeList.txt
5. Sketcher APP: In master - PCH Enabled
6. Sketcher GUI: In master - PCH Not enabled in CMakeList.txt
7. Path APP: PR - PCH ENABLED in CMakeList.txt
8. Path GUI: PR - PCH Not enabled in CMakeList.txt

I won't be able to work for FreeCAD in the following days.

I can move headers as I have done, but I cannot reasonably test PCH impact without overloading the PR/CI system. I do not know if you are interested in deciding on whether to enable them or not depending on whether it makes sense or not.

For the rest of WBs, I can move headers as I have done for these when I am back.

[abdullah]

Well, it seems that we have now travis windows builds running in 50 minutes with the help of clcache:

https://travis-ci.org/FreeCAD/FreeCAD/b ... tification

The tests are not working well yet (some appear not to run, but still they are reported as passing), but that thankfully can be tested in a branch with a PR.

Thanks for your hard work to get it running.

Good work....