binary compatibility: occt + patch?

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
looo
Posts: 2965
Joined: Mon Nov 11, 2013 5:29 pm

binary compatibility: occt + patch?

Postby looo » Tue Jun 04, 2019 9:14 pm

There is a request to add a patch[1] to occt [2] for a reported issue [3]. Now the question is if applying this patch will result in a binary-compatible build. If not we have to rebuild netgen, smesh, freecad with a new occt (A lot of work) So my question is more general:
Which diff of the source lead to binary incompatible builds and which diff result in a binary compatible build?

[1] http://git.dev.opencascade.org/gitweb/? ... 636c2cf130
[2] https://github.com/conda-forge/occt-feedstock/pull/30
[3] https://tracker.dev.opencascade.org/view.php?id=30760
please help with my conda-packaging efforts: https://liberapay.com/looooo/
wmayer
Site Admin
Posts: 15000
Joined: Thu Feb 19, 2009 10:32 am

Re: binary compatibility: occt + patch?

Postby wmayer » Tue Jun 04, 2019 10:10 pm

Now the question is if applying this patch will result in a binary-compatible build.
This won't break binary compatibility.
Which diff of the source lead to binary incompatible builds and which diff result in a binary compatible build?
In general changes to source files (.cpp, .cxx, ..) don't break binary compatibility while changes in header files can break it. This happens when changing the signature of an existing function, removing a function, changing the order of class members or adding new members.

See also
https://stackoverflow.com/questions/371 ... patibility
https://www.acodersjourney.com/20-abi-breaking-changes/
looo
Posts: 2965
Joined: Mon Nov 11, 2013 5:29 pm

Re: binary compatibility: occt + patch?

Postby looo » Wed Jun 05, 2019 6:14 am

Thanks!
please help with my conda-packaging efforts: https://liberapay.com/looooo/
looo
Posts: 2965
Joined: Mon Nov 11, 2013 5:29 pm

Re: binary compatibility: occt + patch?

Postby looo » Sat Jul 20, 2019 8:41 am

I have another question regarding binary compatibility:

boost depends on icu which recently was updated. Is it necessary to rebuild any boost dependent package because of the newer icu version?
please help with my conda-packaging efforts: https://liberapay.com/looooo/
User avatar
kkremitzki
Posts: 1796
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: binary compatibility: occt + patch?

Postby kkremitzki » Sat Jul 20, 2019 7:00 pm

Speaking of this, I'm about to upload OCCT 7.3.0p3 aka 7.3.3 to Debian...
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
Kunda1
Posts: 5947
Joined: Thu Jan 05, 2017 9:03 pm

Re: binary compatibility: occt + patch?

Postby Kunda1 » Sat Jul 20, 2019 7:14 pm

kkremitzki wrote:
Sat Jul 20, 2019 7:00 pm
Speaking of this, I'm about to upload OCCT 7.3.0p3 aka 7.3.3 to Debian...
Nice!
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features