zacl wrote: ↑Fri Jan 10, 2020 2:51 pm
For the origin of macro, is it to know where it will be download or where the installed one come from?
The idea is to show whether the macro comes from the git repository (i.e. it is an "official", peer-reviewed macro) or from the wiki (less control, more freedom).
Kunda1 wrote: ↑Fri Jan 10, 2020 5:15 pm
@zacl thanks so much for leaning in and contributing. I think we need to work on backend functionality before we change GUI stuff. I mean, if you want to tackle GUI simultaneously, that's cool. But make sure to pace yourself and the expectations of the community.
Yeah, I am working on both task. I'm currently studying github api to manage workbench more easily with your headless script and by the same time displaying beautifull description in Qt web. In fact it is more cumbersome for me to accord the current Addon Manager GUI with the headless script than to devellop them parallelly.
HI guys! Regarding this, would it be possible to add an option to force reinstallation of a workbench whe the update fails? This seems to happen when there are modified files in the local clone.
Altought normally regular users won't be messing around with the addon files, in assembly 4's case it seems the user modified the example files that come with it and then was unable to update the workbench. Of course, there was no obvious hint on how to solve this, at least for those who don't know much of git.
adrianinsaval wrote: ↑Wed Jan 22, 2020 1:55 pm
in assembly 4's case it seems the user modified the example files that come with it and then was unable to update the workbench.
vocx wrote: ↑Sun Feb 16, 2020 7:14 pm
... And an improvement for the future would be to categorize the workbenches and modules in the Addon Manager, similar to External workbenches, subject to discussion of course.
I'm getting close to submitting a PR for the AddOnManager which includes a Python 2 Only list. At present I've got animation, geodata, GDT and timber Wbs in the list.
If there are any others that should be added then please advise, otherwise they can be PR'd at a later date.
Also included in my changes are checks around the Git binary version, I've found some really strange results when trying to update with 2.12.1 but wasn't aware that I had another version (2.15) later in my path which was being ignored, so I've tried to at least make the user aware is their version doesn't meet the minimum. Seeing as I believe current stable version is 2.26 and the version that was installed on my Linux Mint 19.3 partition was 2.17 then I don't think it's unreasonable to advise the user to update.
Attached is a copy of src\Mod\AddonManager\addonmanager_workers.py and addonmanager_utilities.py files if anyone wants to try and break it.
Traceback (most recent call last):
File "D:\FreeCAD-build\Mod\AddonManager\addonmanager_workers.py", line 159, in run
git_version = StrictVersion(result.group(1))
AttributeError: 'NoneType' object has no attribute 'group'
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.20940 (Git)
Build type: Release
Branch: master
Hash: 99ec5924d1e12b3b01ad753a37b5b119999c489d
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)