realthunder wrote: ↑Tue Aug 27, 2019 6:33 am...
Any concrete example of having an extra Shape property breaking anything? I mean I have already modified the logic so that if Part.getShape() can't get anything, it won't provide the default 'Shape'. But if it can, will it break anything?
I think some tools from Arch also do the tests that DeepSOIC mentions, maybe Arch SectionPlane to extract the objects to cut and project.DeepSOIC wrote: ↑Tue Aug 27, 2019 11:36 amIn there, the main use of hasattr(.., 'Shape') was to a) pick the objects to include in the compound, and b) tell apart Bodies (which totally have a useful Shape and should not be explored inside),...
In any case, my position is the same as furti's: it sounds as fundamentally bad design; however, if you already fixed this, and some objects don't provide a shape, then maybe it's a non-issue after all. We will have to keep testing and see if everything works as expected.