GitHub CodeQL (formerly Semmle LGTM)

[Chris_G]

Thanks Saso,
This is a very interesting tool.

(hopefully you are not angry about it Chris )

You could have choosen a "good" test workbench.
The number of errors put a shame on me ...

[saso]

You could have choosen a "good" test workbench.
The number of errors put a shame on me ...

What, there are just 8 errors don't feel like having to fix all of it, take it just informational and to review errors and warnings is more important then the recommendations... Now that it is set up, this should be creating this reports automatically daily from the latest code, so unless you want to set up some configurations, there is nothing else to do, except reviewing the results from time to time of course

[Chris_G]

Thanks. I bookmarked it.

[yorik]

I added the LGTM python quality badge to our readme. I think it will be a great incentive to polish our python code...

[Kunda1]

First PR with some initial LGTM recommended fixes
It's educational

[Kunda1]

Took care of all the s/== None/is None/ LGTM issues and some other issues in:
https://github.com/FreeCAD/FreeCAD/pull/2645
https://github.com/FreeCAD/FreeCAD/pull/2648
https://github.com/FreeCAD/FreeCAD/pull/2649

[ezzieyguywuf]

Took care of all the s/== None/is None/ LGTM issues and some other issues in:
https://github.com/FreeCAD/FreeCAD/pull/2645
https://github.com/FreeCAD/FreeCAD/pull/2648
https://github.com/FreeCAD/FreeCAD/pull/2649

*nods* “x is None” should def be used

[saso]

Took care of all the s/== None/is None/ LGTM issues and some other issues in:

yay, you have pushed it to code quality A

[yorik]

yay, you have pushed it to code quality A

Excellent!!!

[Kunda1]

yay, you have pushed it to code quality A

There are still many more recommendations for us to consider