[Solved] memory leak in distToShape

[looo]

Encountered this when using this function for a least-square calibration.

To reproduce:

Code: Select all

import Part as part
a = part.Vertex(0,0,0)
b = part.Vertex(1,1,1)
for _ in range(int(3e6)):
    dist = a.distToShape(b)
    del dist

Bildschirmfoto von 2019-12-12 10-18-00.png (19.88 KiB) Viewed 1244 times

Code: Select all

OS: Ubuntu 18.04.3 LTS (ubuntu:GNOME/ubuntu)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18846 (Git)
Build type: Release
Branch: master
Hash: ceeb776fff25c679752571d5d8e6c4c8b1fd9008
Python version: 3.7.3
Qt version: 5.12.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)

[openBrain]

Confirmed with :

Code: Select all

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18934 (Git)
Build type: Release
Branch: master
Hash: 540aeada3a5d1e460cb30671af4bb9a747def942
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)

[DeepSOIC]

Code: Select all

>>> a = Part.Vertex(0,0,0)
>>> b = Part.Vertex(1,1,1)
>>> dist = a.distToShape(b)
>>> import sys
>>> sys.getrefcount(dist)
2
>>> sys.getrefcount(dist[0])
2
>>> sys.getrefcount(dist[1])
3
>>> sys.getrefcount(dist[2])
3
>>> sys.getrefcount(dist[1][0])
3
>>> sys.getrefcount(dist[2][0])
3

where refcount is 3, a reference was leaked.

[DeepSOIC]

I'm busy fixing it...

EDIT: it's going to take a while longer than expected, as updating the source somehow nuked my build setup, I'm recovering it.

[DeepSOIC]

PR #2771

[DeepSOIC]

PR canceled, because there are more problems with refcounting. Now the test crashes FreeCAD as a result of deallocating None.

[DeepSOIC]

Done, new PR:
https://github.com/FreeCAD/FreeCAD/pull/2772

[looo]

Thanks @DeepSOIC. I cherry-picked the PR but updated libraries previously and now my local build is not working anymore. I will trigger ci's as soon as it is merged (the lazy way).

[wmayer]

It's merged now.

[Kunda1]

git commit 693130d86
git commit cbe19e396
git commit 6af98e080f