Should release 0.19 be compatible with Python 2.7.x ?

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
bernd
Posts: 9301
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Should release 0.19 be compatible with Python 2.7.x ?

Postby bernd » Fri Jan 17, 2020 2:10 pm

Just merged some code to be compatibel with Python 3.8. This code seams not compatible with Python 2.7.x The question came up. Do we need to compatible with Python 2.7.x in 0.19 release? ATM we have to as long as travis for py 2 is active. See https://github.com/FreeCAD/FreeCAD/pull ... -575382546

Any comments are welcome.


If there has been an official statement or a topic in this regard already kindly excuse my ignorance :o. I could not found anything.

cheers bernd
wmayer
Site Admin
Posts: 15487
Joined: Thu Feb 19, 2009 10:32 am

Re: Should release 0.19 be compatible with Python 2.7.x ?

Postby wmayer » Fri Jan 17, 2020 2:34 pm

For v0.19 it was always said to drop Py2. But since we still have the travis tests running and if fixes are trivial like this one I think we should just do it.
User avatar
bernd
Posts: 9301
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Should release 0.19 be compatible with Python 2.7.x ?

Postby bernd » Fri Jan 17, 2020 4:41 pm

wmayer wrote:
Fri Jan 17, 2020 2:34 pm
For v0.19 it was always said to drop Py2. But since we still have the travis tests running and if fixes are trivial like this one I think we should just do it.
That would mean as long as 0.19 is not released we do not drop any Python 2 related code. We try to keep travis Py2 up for 0.19 release. This totally makes sense IMHO.
wmayer
Site Admin
Posts: 15487
Joined: Thu Feb 19, 2009 10:32 am

Re: Should release 0.19 be compatible with Python 2.7.x ?

Postby wmayer » Sat Jan 18, 2020 11:22 am

User avatar
bernd
Posts: 9301
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Should release 0.19 be compatible with Python 2.7.x ?

Postby bernd » Sat Jan 18, 2020 11:55 am

cool, much smarter than I would have done it.
User avatar
uwestoehr
Posts: 1366
Joined: Sun Jan 27, 2019 3:21 am

Re: Should release 0.19 be compatible with Python 2.7.x ?

Postby uwestoehr » Thu Jan 30, 2020 12:21 am

wmayer wrote:
Fri Jan 17, 2020 2:34 pm
For v0.19 it was always said to drop Py2.
I think we could release a version of FC right now that has for the last time official Py2 and Qt4 support and opened a "request for comments" thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=42904