I'd like to invite everyone interested, with some knowledge of FreeCAD and Python or C++ coding and who can compile FreeCAD themselves, to help reviewing FreeCAD pull requests at https://github.com/FreeCAD/FreeCAD/pulls
. Anyone with a github account can review PRs. You only need to click a pull request, go to the "Files changed" tab, and press the green "Review changes" button.
If you have little time to spare, this can help greatly to speed up the PR approval process. Even if the code seems too complicated to you (it happens often to me
), if you are able to compile FreeCAD, just compiling the PR and running FreeCAD and shake it a bit just to test the proposed functionality or change and that everything still works fine, is extremely useful.
Specially some large pull requests, some of @realthunder for example, are complex and complicated to review, and beyond the scope of anyone, (except Werner of course), and in that case, the only way to assess if the code is safe to merge, is not by looking at the code but by compiling and testing. The more people willing to test and make a positive review, or indicate problems, the easier it is to assess and the faster we can merge them.
I would only ask, if you make a review, to not just press the "approve" or "reject" button, but also write why you do so, and explain just a bit what you did (you tested the code, or just read the code, etc) so other people interested in reviewing can know better