Helping to review pull requests

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
yorik
Site Admin
Posts: 11978
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Helping to review pull requests

Postby yorik » Fri Jul 17, 2020 1:37 pm

spanner888 wrote:
Thu Jul 09, 2020 11:27 am
and please add spanner888 on github
Done!
markus23
Posts: 11
Joined: Sun May 24, 2020 11:35 am

Re: Helping to review pull requests

Postby markus23 » Fri Jul 24, 2020 5:33 pm

Please add also me: markus2330

Thank you ;)
User avatar
vanuan
Posts: 179
Joined: Wed Oct 24, 2018 9:49 pm

Re: Helping to review pull requests

Postby vanuan » Tue Jul 28, 2020 11:38 pm

GitHub username: vanuan

Experienced programmer having some spare time due to pandemic.
TheMarkster
Posts: 1729
Joined: Thu Apr 05, 2018 1:53 am

Re: Helping to review pull requests

Postby TheMarkster » Fri Jul 31, 2020 3:16 am

yorik wrote: pinged by pinger macro
Add me github user mwganson
My FreeCAD video series on youtube: https://www.youtube.com/c/mwganson
marioalexis
Posts: 3
Joined: Wed Jun 19, 2019 7:44 pm

Re: Helping to review pull requests

Postby marioalexis » Sun Aug 02, 2020 3:25 am

Hi
user marioalexis84
User avatar
freman
Posts: 1158
Joined: Tue Nov 27, 2018 10:30 pm

Re: Helping to review pull requests

Postby freman » Wed Aug 05, 2020 9:18 pm

Not making any promises but I can see this may help speed up PRs getting processed.
J-Dunn on github.

I assume that members of this new group will not actually be able to merge, just post a +ve or -ve review: a bit like peer review for PRs. Sounds like a good idea. I hope it works better than peer review !