Helping to review pull requests

[yorik]

Please add me, I hope i can help the community.

Remind me what is your github username?

[Kunda1]

Please add me, I hope i can help the community.

Remind me what is your github username?

@ebrahimraeyat

[ebrahim raeyat]

Please add me, I hope i can help the community.

Remind me what is your github username?

@ebrahimraeyat

Thanks Kunda1

[yorik]

Thanks! You are added Ebrahim!

[ebrahim raeyat]

Thanks! You are added Ebrahim!

Thanks, it is very interesting, I am a member of FreeCAD

[davidosterberg]

I volunteer to be a reviewer my GitHub Id is @davidosterberg

[yorik]

I volunteer to be a reviewer my GitHub Id is @davidosterberg

Added!

[DrInfiniteExplorer]

I'd like to review some as well. Github id is DrInfiniteExplorer

Edit: But I haven't been able to find any guidelines for code style, formatting, pep8, typing, or review process in general.
Does any of that exist for FreeCAD?

[yorik]

Added!

Note for future people interested, this is apparently not needed anymore, anyone can start a review on the FreeCAD pull requests. And your contributions will be there the same way, visible to all

About code style guides, no, we haven't anything really official, although many people have tried starting things like that... At the moment I'd say we look more to have things that are more or less well constructed and don't break anything. FreeCAD also being a very hybrid code with different languages and libraries makes it harder to get everyone to follow one determined code styling.

[openBrain]

Added!

Note for future people interested, this is apparently not needed anymore, anyone can start a review on the FreeCAD pull requests. And your contributions will be there the same way, visible to all

As I said in another thread, while I think it's good to have a bunch of reviewers, this is more important to have a review process especially stating clearly what are the expectations from the trusted mergers so a PR is considered 'mergeable'. If it appears that @wmayer only trusts himself (which would be an acceptable statement) to review and merge a PR in App or Part or PartDesign, better know it so nobody wastes time.
PS : also define how reviewers shall flag PR when it is reviewed OK.