Reverse Engineering Workbench status
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Reverse Engineering Workbench status
As I was working on getting our codebase compiling under the C++17 standard today I ran across some minor issues with the Reverse Engineering Workbench. It seems that it's using a few features that were deprecated in C++11 and removed in C++17. It's not a big deal to replace those things with their C++17-compatible equivalents, but before I did so I thought I'd check to make sure that's the correct way forward -- the alternative is to remove that workbench (or at least, don't compile it), since it seems like it's been unmaintained for quite some time.
Re: Reverse Engineering Workbench status
That's wmayer's territory.
wmayer wrote: pinged by pinger macro
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: Reverse Engineering Workbench status
For the record, it's really just the Windows Libpack version of FLANN that's the issue -- they haven't actually issued a formal release sine 2016, so even though the GitHub repo has the C++17 compatibility fixes, we haven't packaged it up on Windows. We probably ought to do so regardless, so it's not really anything that has to change in RE.
Re: Reverse Engineering Workbench status
Unfortunately, I can work on this Wb only from time to time. So, at the moment there is not much functionality and maybe looks unmaintained but it shouldn't be removed.the alternative is to remove that workbench (or at least, don't compile it), since it seems like it's been unmaintained for quite some time.
Re: Reverse Engineering Workbench status
OK - I will work with apeltauer to get an updated FLANN into the LibPack.
Re: Reverse Engineering Workbench status
+ FLANN also added to the CMake summary (it's installed via PCL, I believe)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
- matthiaswm
- Posts: 35
- Joined: Wed Nov 18, 2020 11:41 am
- Location: Düsseldorf, Germany
Re: Reverse Engineering Workbench status
Did you get it to compile in the end? How?
I am trying to compile Reverse Engineering with Point Cloud Library enabled (current GIT), but even when setting the Module to C++14, compilation will fail (std::random_shuffle no longer exists). I could not get the current version of Flann to compile under VisualC 2019 either (CMake complains that PkgConfig is missing, and other stuff).
Any suggestions?
Re: Reverse Engineering Workbench status
I believe all I had to do was switch out the FLANN library in the LibPack with the latest HEAD from their GitHub.