[fixed] [regression] broken encoding in About dialog

[uwestoehr]

conda weekly builds even for win:
No doc folder -> no CONTRIBUTORS file -> no Contrib tab

That should be fixed.

There is no need to save something. The weekly builds are for testing but how can I test something I can't test?
I guess this "saving" is the reason why we have substantial doc errors also in the releases. Take for example that "What's this" doesn't work for some complete WBs and that e.g. for the Std features, we only offer help pages that only contain one line. So in this respect we should do something and since data size is no big deal nowadays, it doesn't harm to have bigger weekly packages.

[chrisb]

Code: Select all

App.getHelpDir()

/Users/cb/Desktop/FreeCAD.app/Contents/Resources/share/doc/FreeCAD/

and where in your FreeCAD installation you have the file "CONTRIBUTORS"?

This file doesn't exist in the distro.

[chennes]

Offline Docs are only included in the release bundles.

Can we exclude the full docs but still include LICENSE.html and CONTRIBUTORS? Or would it be best to move those two files elsewhere?

[sgrogan]

Can we exclude the full docs but still include LICENSE.html and CONTRIBUTORS? Or would it be best to move those two files elsewhere?

We should include them and ThirdPartyLibraries.html, this is what I do for the Libpack builds. I will make a pull request on the FreeCAD-Appimage repo. It may take a couple days.

That should be fixed.

There is no need to save something.

The Offline docs are 220 MB and don't change over the course of the dev cycle. They can be downloaded once from https://github.com/FreeCAD/FreeCAD/releases/tag/0.19.1 Then add them or create the doc sub-directory.

[chennes]

We should include them and ThirdPartyLibraries.html, this is what I do for the Libpack builds. I will make a pull request on the FreeCAD-Appimage repo.

Awesome, thank you. I did not think about packaging issues when I changed the About code.

[chrisb]

I have the Credits in the release version - thanks looo! - and the encoding is correct here.
I appreciate to have a smaller development version and think including Credits in the stable versions should be enough.

[looo]

conda weekly builds even for win:
No doc folder -> no CONTRIBUTORS file -> no Contrib tab

That should be fixed.

There is no need to save something. The weekly builds are for testing but how can I test something I can't test?
I guess this "saving" is the reason why we have substantial doc errors also in the releases. Take for example that "What's this" doesn't work for some complete WBs and that e.g. for the Std features, we only offer help pages that only contain one line. So in this respect we should do something and since data size is no big deal nowadays, it doesn't harm to have bigger weekly packages.

Idk. There are different opinions...
I prefer some alpha releases before a final release is made where we include all the docs.

Also I see the point: why including asm3 and glider workbench while not shipping the docs... Doesn't make a lot of sense. On the other hand I don't want to distribute another freecad bundle only for the glider workbench.

[chrisb]

We could have the smaller regular version and a big one every two months or so.

[sgrogan]

Looks like this is going to take me a little longer, the files aren't available in the conda build.
I can copy the LICENSE.html and CONTRIBUTORS from the src tree, but I don't know what to do about the ThirdPartyLibraries.html?