Back port commits to 0.19 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

jnxd wrote: Mon Sep 20, 2021 1:17 am A bunch of PR's and commits around issue #4098 and it's forum posts, some merged and some not:
thanks, added to the list
User avatar
chennes
Veteran
Posts: 3881
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

These are really mostly notes for myself as I process these, but I may as well make them here so you can see what's going on. First off, I'm personally ignoring Arch, Path, and Sketcher because Yorik, Sliptonic, and Abdullah are definitely point on those. That leaves (currently) nine proposed backports for me to look into. I'm adding short notes after each indicating the size, plus comments:
uwestoehr wrote: Sun Apr 11, 2021 12:30 am Memory leak or dataloss fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4792 (+1 -0 probably safe)

Addon manager fixes:
* https://github.com/FreeCAD/FreeCAD/pull/5041 (+9 -5 safe)

Core (App and Gui) fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4792 (already listed above)
* https://github.com/FreeCAD/FreeCAD/pull/4800 (+4 -5 probably safe, as long as it actually aborts save)
* https://github.com/FreeCAD/FreeCAD/pull/4996 (+117 -21 big, causes other problems, maybe not needed with 4792 and 4800)
* https://github.com/FreeCAD/FreeCAD/pull/5045 (+2 -3 Not merged to trunk yet)

Draft fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4743 (+3 -0 Seems pretty minor)

TechDraw fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4895 (+22 -1 probably safe)

Stylesheet issues:
* https://github.com/FreeCAD/FreeCAD/pull/4694 (+170 -16 importance ??)

Miscellaneous:
* https://github.com/FreeCAD/FreeCAD/pull/4771 (+4 -4 safe)
So by my count that's 4792, 5041, 4800, 4895, and 4771 as the obvious candidates: they will almost certainly merge without issue, and are highly unlikely to cause any problems. I'm pretty hesitant about 4996 and 5045, especially in light of 4800 and 5041, which at least abort the quit process so the user can handle the problem. I'm also a bit hesitant on 4694 because we're doing file renames there, and it's hard to do adequate testing on that, and 4743 just seems sort of minor... is it really worth the backport?

So my thought process is that I'm going to backport the five obvious ones for sure. The rest please feel free to comment on here so I can understand the issues better.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

chennes wrote: Tue Sep 21, 2021 4:04 am So by my count that's 4792, 5041, 4800, 4895, and 4771 as the obvious candidates:
Many thanks for having a look!
Can you please update the list accordingly?

@chrisb, can you please give @chennes the rights to modify existing forum posts since he is now a developer with merging rights?

chennes wrote: Tue Sep 21, 2021 4:04 am So my thought process is that I'm going to backport the five obvious ones for sure. The rest please feel free to comment on here so I can understand the issues better.
Thanks. I think the best is to add a comment in parentheses behind the list entry that info and what info is missing. Then add a note to the PR that the PR authors are informed and can react

chrisb wrote: .
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.19 branch

Post by chrisb »

uwestoehr wrote: Wed Sep 22, 2021 4:37 pm @chrisb, can you please give @chennes the rights to modify existing forum posts since he is now a developer with merging rights?
I am no admin. Besides, the rights for merging code and forum moderation are different things.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
chennes
Veteran
Posts: 3881
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

chrisb wrote: Wed Sep 22, 2021 11:07 pm rights for merging code and forum moderation are different things
+1, please don't sign me up for forums moderation. Been there, done that!
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.19 branch

Post by chrisb »

chennes wrote: Wed Sep 22, 2021 11:35 pm Been there, done that!
:lol:
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: Back port commits to 0.19 branch

Post by GeneFC »

chennes wrote: Wed Sep 22, 2021 11:35 pm Been there, done that!
As an all-powerful moderator :lol: :lol: :lol: I have the ability to edit posts that are not my own. I almost never do that because it is too powerful and often not quite fair to the original poster. About 99% of the time I use the "power" to add an image that someone had merely linked.

At the same time a moderator can do as much or as little as desired. There are quite a few.

Gene
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.19 branch

Post by chrisb »

GeneFC wrote: Thu Sep 23, 2021 12:06 am As an all-powerful moderator :lol: :lol: :lol: I have the ability to edit posts that are not my own. I almost never do that because it is too powerful and often not quite fair to the original poster.
That's my strategy too. Often my fingers itch to edit a post, but the only thing I frequently do, is to move it to the right forum. And even that is not done silently, I add a post making the OP aware of what happened.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

chennes wrote: Wed Sep 22, 2021 11:35 pm please don't sign me up for forums moderation.
You misunderstood me, no need to moderate anything. The idea of the backport list is that developers who can actually backport things, can edit the list. Up to now Werner did so when he backported, and all I want you to to do is to edit the list. To do this, you need moderator rights.
Post Reply