Back port commits to 0.19 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: Back port commits to 0.19 branch

Post by turn211 »

uwestoehr wrote: Mon Apr 12, 2021 12:15 am I think we need a stable release maintainer. Someone who decides what is backported and when there are either enough fixes or a severe bugfix, decides for a new release.

For now I'll try to keep the initial post up to date to keep the overview.

From my perspective we already agree that a 0.19.2 release should be made to make FC 0.19 usable with stylesheets. So all fixes related to styles should go in. They don't change FC's functionality and I know that a lot of users love customized program interfaces.
Don't think we need a supreme dictator but need a face that sees the FreeCAD project from the users eyes. Why not you as the backport maintainer? :)
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

adrianinsaval wrote: Mon Apr 12, 2021 2:22 am potentially related memory leak stuff:
Thanks, I added them to the list: https://forum.freecadweb.org/viewtopic. ... 59#p495659

These fixes are made by Werner so he knows what should be backported.
wmayer wrote: .
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Back port commits to 0.19 branch

Post by wmayer »

uwestoehr wrote: Mon Apr 12, 2021 2:33 pm These fixes are made by Werner so he knows what should be backported.
This is the most important one git commit 4e4068e44f4df0 since it releases most of the leaking memory. The other commits are negligible in terms of releasing memory.
And even now the problem is not entirely solved in master. The right way would be to use Python's weak reference API that doesn't increment the reference counter of cached objects but it's pretty hard to extend our custom Python wrappers by that functionality.
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Back port commits to 0.19 branch

Post by wmayer »

Stylesheet issues:
The first one in the list can be considered as bug fix but the other PRs aren't.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: Back port commits to 0.19 branch

Post by Syres »

Has my suggestion git commit 8ec9bfa been removed from the list for some reason, it's not only a fix but has been reported multiple times on 0.19.1 hence my request?
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

Syres wrote: Wed Apr 14, 2021 1:38 pm Has my suggestion git commit 8ec9bfa been removed from the list for some reason,
It is again in the list since it was already backported to the 0-19 branch today.

So for 0.19.2 there are only two stylesheet PRs left.
steelman
Posts: 48
Joined: Wed Jul 05, 2017 9:25 am

Re: Back port commits to 0.19 branch

Post by steelman »

Shameless plug (-: These are small fixes for annoyances I found in 0.19 on Debian. Debian isn't particularly fast in bumping versions but they do integrate patches. Please pick these.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.19 branch

Post by Kunda1 »

steelman, thanks for the contributions, btw!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

steelman wrote: Mon Apr 26, 2021 6:20 am These are small fixes for annoyances I found
Thanks, I added them to the list. I think I would not harm when you keep the branches open when you like to to have them merged to 0.19. Of course merging also works from master but I assume that merging from master can be more complicated for the mergers than to merge from the PR branch.
matthijskooijman
Posts: 72
Joined: Thu Mar 25, 2021 10:59 am

Re: Back port commits to 0.19 branch

Post by matthijskooijman »

I would like to nominate https://github.com/FreeCAD/FreeCAD/pull/4780 (at least commit f0c99c16f6122bce9ba0c491f526a04943f15a16, the other is just a doc fix) for backporting.
Post Reply