Back port commits to 0.19 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: Back port commits to 0.19 branch

Post by Syres »

chennes wrote: Fri Oct 08, 2021 8:12 pm we should begin testing for a new incremental 0.19.3 release.
A present FreeCADLibs_12.5.4_x64_VC17 used to produce the Windows installer version has OCC 7.5.0, is there going to be an upgrade to OCC 7.5.2 and therefore produce FreeCADLibs_12.5.5_x64_VC17?
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.19 branch

Post by chrisb »

I wouldn't change the OCC version in a bugfix release. This could break existing models. And there is always the current development version for those who want the latest.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: Back port commits to 0.19 branch

Post by Syres »

chrisb wrote: Sat Oct 09, 2021 8:46 am I wouldn't change the OCC version in a bugfix release. This could break existing models. And there is always the current development version for those who want the latest.
Fair enough, bizarrely it's the fact that 0.20 breaks cylinders from 0.19 files was one of the reasons for the question, so instead I'll look to enhance the 0.20 code to bring in 0.19 cylinders without applying the change but give the user the ability to add the new feature if required.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

Russ4262 wrote: Sat Oct 02, 2021 6:35 pm Thanks for allowing me to contribute to FreeCAD.
I think it is the other way round - you do a great job in developing FC. Thanks that you joined the development and keep on going!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

Syres wrote: Sat Oct 09, 2021 8:15 am A present FreeCADLibs_12.5.4_x64_VC17 used to produce the Windows installer version has OCC 7.5.0, is there going to be an upgrade to OCC 7.5.2 and therefore produce FreeCADLibs_12.5.5_x64_VC17?
I opened a new thread to discuss this:
https://forum.freecadweb.org/viewtopic.php?f=10&t=62798
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

Since Coin3D changed its website, we should also backport this PR, to fulfill the Coin3D license:
https://github.com/FreeCAD/FreeCAD/pull/5103
User avatar
chennes
Veteran
Posts: 3881
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

uwestoehr wrote: Sat Oct 09, 2021 5:25 pm Since Coin3D changed its website, we should also backport this PR, to fulfill the Coin3D license:
https://github.com/FreeCAD/FreeCAD/pull/5103
I manually backported that change, since the commit wouldn't apply cleanly due to a minor change in nearby code.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

chennes wrote: Sat Oct 09, 2021 6:25 pm I manually backported that change
Thanks!
torsen
Posts: 7
Joined: Thu Jan 28, 2021 10:23 am

Re: Back port commits to 0.19 branch

Post by torsen »

Is it possible add PR #5076 (https://github.com/FreeCAD/FreeCAD/pull/5076) to 0.19 branch?

Thanks.
User avatar
chennes
Veteran
Posts: 3881
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

Maybe just git commit 9fbd22745?
sliptonic wrote: Ping.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
Post Reply