Back port commits to 0.19 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
chennes
Veteran
Posts: 3879
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

Thanks for doing this, Russell.

I know I can't speak for all devs, but in the interest of transparency... the PRs that I decided to backport I did on the basis of two main criteria: first, they must be bug fixes, and second they must be simple enough that they are unlikely to introduce their own new bugs into the release. I view it as a tradeoff: the more severe the bug being fixed, the more code I think it's OK to backport to achieve the fix. IMO a trivial one-line fix that pretty obviously can't break anything, like PR 4680, is a clear "yes". Whereas PR 4673 is enough code that I'd want to make sure the bug it's fixing is pretty important before risking it. I looked through your list and I think those are all great candidates.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
sliptonic
Veteran
Posts: 3457
Joined: Tue Oct 25, 2011 10:46 pm
Location: Columbia, Missouri
Contact:

Re: Back port commits to 0.19 branch

Post by sliptonic »

The vast majority of 4673 is removing code that has been deprecated for a very long time. All the stuff that is wrapped in 'hasattr' is checking for an attribute that hasn't existed on jobs for years.

It probably should have been two separate commits. My bad.
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Back port commits to 0.19 branch

Post by abdullah »

Ok. I have been hinted to come here for the two Sketcher PRs.

Those two should merge clean.

What am I expected to do, to merge them to the 0.19 branch?
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

abdullah wrote: Mon Oct 04, 2021 11:20 am Ok. I have been hinted to come here for the two Sketcher PRs.
That was me :oops: ;)

abdullah wrote: Mon Oct 04, 2021 11:20 am What am I expected to do, to merge them to the 0.19 branch?
Yes. And then modify the list by adding a note behind that you did the backport for 0.19.3.
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Back port commits to 0.19 branch

Post by abdullah »

uwestoehr wrote: Mon Oct 04, 2021 4:59 pm That was me :oops: ;)
It was not only you.

Done.
User avatar
chennes
Veteran
Posts: 3879
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

sliptonic wrote: Mon Oct 04, 2021 2:09 am The vast majority of 4673 is removing code that has been deprecated for a very long time.
I was really just looking for a long-ish example from within the suggested commits... obviously you can eyeball all of those Path suggestions better than anyone else! I don't have any reason to actually object to any of them.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

abdullah wrote: Mon Oct 04, 2021 6:59 pm Done.
Many thanks!
User avatar
sliptonic
Veteran
Posts: 3457
Joined: Tue Oct 25, 2011 10:46 pm
Location: Columbia, Missouri
Contact:

Re: Back port commits to 0.19 branch

Post by sliptonic »

In addition to the four listed on Page 1, the following have been added.
  • [PATH] Fix bug with spindle not restarting #4613, (added for v0.19.3)
  • [Path]: Bugfix/job setup #4622, (added for v0.19.3)
  • Path: vcarve - Fix depth calculation #4680, (added for v0.19.3)
  • [PATH] fix bug adding TC from job dialog. #4765, (added for v0.19.3)
  • [PATH] Fix proxy error bug that occurs when postprocessing #4673, (added for v0.19.3)
  • Path: Fix readonly lockout bug with blank expression, [commit]Path: Fix readonly lockout bug with blank expression[/commit] (added for v0.19.3)
  • Path: Fix bug with inaccurate Task Panel values upon new op creation, git commit 527e168be275e0f14212cf90e29fcda1dc503684 (added for v0.19.3)
  • [path] fix minor bug when cancelling post process #4819, (added for v0.19.3)
  • [Path] bug splitting gcode by Fixture #4864 (added for v0.19.3)
  • Path: Fixes FreeCAD#4647, relative shape file locations, git commit 6db5c26b98450f0bf2e9ac3f86a8786bc3a26363 (added for v0.19.3)
  • Path: Fix relative paths for bit path attributes in library files, git commit 430116a18668997e134ecba30f8893bfc4767d7b (added for v0.19.3)
  • [Path] Remove Side assignment to Outside for full model profiles #4919 (added for v0.19.3)
    Path: Updatre 45degree_chamfer.fctb db16029c6a8f8af6d1a7c4428981b0c632016da3 (added for v0.19.3)
  • Path: fix invalid JSON in 45degree_chamfer.fctb tool bit #4953, (added for v0.19.3)
  • Path: Fix Face Region boundary shape usage , git commit fcd8b8558e269bb01346820d31308b61a86c671e (added for v0.19.3)
  • Path: fix grbl --return-to placement #4936, (added for v0.19.3)
  • Path: Add missing newline to return-to statement in grbl postprocessor #4986, (added for v0.19.3)
  • [Path] post procesing for GRBL with option "--translate_drill" should also suppress G99 #4639, (added for v0.19.3)
    downgrade setupsheet debug level 1cdfd611fd85fc199652af053e34f32ae9671aa5 (added for v0.19.3)
[/quote]
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

sliptonic wrote: Thu Oct 07, 2021 6:46 pm In addition to the four listed on Page 1, the following have been added.
Many thanks! This brings us close to a new 0.19 release.

The idea of the list at the initial post is that every developer can change it. Could you therefore please add the new items there and add a note to existing ones that they have been merged for 0.19.3.
(I can also do this if you like).
User avatar
chennes
Veteran
Posts: 3879
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

OK, I merged the Draft and Arch fixes. I think the remaining un-merged suggestions should probably stay that way, and we should begin testing for a new incremental 0.19.3 release.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
Post Reply