Back port commits to 0.19 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Back port commits to 0.19 branch

Post by bernd »

damn there is no way in gitlab to run a pipeline with ckiped ci in commit message ... we need to wait until the next commit is in 0.19 ... https://github.com/FreeCAD/FreeCAD/comm ... 2fc7c5e374

Is there any patch we could apply to 0.19 ... ;)
User avatar
chennes
Veteran
Posts: 3884
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

bernd wrote: Fri Oct 01, 2021 8:13 pm Is there any patch we could apply to 0.19 ... ;)
PR 4909 is a trivial Path fix that should apply cleanly.

ETA - Sorry, original post had the wrong commit linked!
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Back port commits to 0.19 branch

Post by bernd »

bernd wrote: Fri Oct 01, 2021 8:13 pm damn there is no way in gitlab to run a pipeline with ckiped ci in commit message ... we need to wait until the next commit is in 0.19 ... https://github.com/FreeCAD/FreeCAD/comm ... 2fc7c5e374

Is there any patch we could apply to 0.19 ... ;)
fix for 0.19 https://github.com/FreeCAD/FreeCAD/comm ... 82f98062a5

pipeline https://gitlab.com/berndhahnebach/FreeC ... /381150129
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

bernd wrote: Fri Oct 01, 2021 8:20 pm fix for 0.19 https://github.com/FreeCAD/FreeCAD/comm ... 82f98062a5
You eventually made it :)
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.19 branch

Post by uwestoehr »

chennes wrote: Thu Sep 30, 2021 3:16 pm I have backported the PRs that were on my list to handle to the 0.19 branch, all of them applied cleanly. If anyone has free time, it would be good for other people to check out the head of that branch (not the release tag) and try to compile and run 0.19.x. Thanks!
I checked out the 0.19 branch and it compiles and runs fine so far. Many thanks.
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Back port commits to 0.19 branch

Post by bernd »

It compiles on the CI but the unit tests fail... Anyone a idea which else commit is needed?
https://gitlab.com/berndhahnebach/FreeC ... /381150129
User avatar
chennes
Veteran
Posts: 3884
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Back port commits to 0.19 branch

Post by chennes »

bernd wrote: Sat Oct 02, 2021 2:49 am Anyone a idea which else commit is needed?
I'd guess git commit 20c4c369b (see forums discussion here).
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Back port commits to 0.19 branch

Post by bernd »

User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Back port commits to 0.19 branch

Post by bernd »

passed :D
Russ4262
Posts: 941
Joined: Sat Jun 30, 2018 3:22 pm
Location: Oklahoma
Contact:

Re: Back port commits to 0.19 branch

Post by Russ4262 »

Good day,
This first quote points to the first set of suggested Path candidates.
Russ4262 wrote: Wed Jul 28, 2021 4:35 pm ... At the moment, these commits come to mind: ...

This list contains other possible candidates. I ask that @Sliptonic or @MLampert sort through the candidates I have identified to formally identify the real PATH candidates. I have no experience with backports, the philosophy or methodology behind a backport, nor do I know any of the criteria for identifying candidates. The list I have compiled in this post combined with the four in my first post are all bug fixes since I feel confident that one requirement is that FreeCAD backports must be bug fixes.
sliptonic wrote:Ping
mlampert wrote:Ping
Thanks for allowing me to contribute to FreeCAD.

Russell
Post Reply