The two cases that seemed obvious to me, and for which I have a code change ready to go (see the diff, without a PR here), are:
- In BackupPolicy::applyStandard() (App/Document.cpp line 2392) a temporary save file is renamed to the project filename (finalizing the save). If this fails, currently only a warning is logged, but the save is reported as a success.
- Similarly, in BackupPolicy::applyStandard() (App/Document.cpp line 2534) the same thing happens, with the same consequences.
However, I'm less certain about other cases. For example, what should happen when there's a failure to remove a backup file (as part of maintaining some policy), but not in saving the main project file?
Edited to add links to two relevant PRs: