[fixed] Github links to commits are invalid

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

[fixed] Github links to commits are invalid

Post by uwestoehr »

I encountered that nowadays links to commits of a PR are broken.

To test here a screencast in which I try to open the commit of PR 4942 (you can test with any other PR as well):
screencast
screencast
DiVcXXU8Zr.gif (535.25 KiB) Viewed 940 times

The bug is the following:
- the links pointing to the commit is
https://github.com/donovaly/FreeCAD/pul ... ec2e40c472
but the correct link would be
https://github.com/FreeCAD/FreeCAD/pull ... ec2e40c472

Can we do something or is this a bug in Github we can only report to the Github guys?
Last edited by uwestoehr on Mon Sep 20, 2021 4:46 pm, edited 1 time in total.
User avatar
kkremitzki
Veteran
Posts: 2511
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: [regression] Github links to commits are invalid

Post by kkremitzki »

Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] Github links to commits are invalid

Post by uwestoehr »

kkremitzki wrote: Mon Sep 20, 2021 12:34 pm Apparently a GitHub bug: https://twitter.com/bagder/status/1439701810718117889
Thanks. And the GitHub guys fixed it today. 8-)
Post Reply