[fixed] master not compilable since commit 5593b8499

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

[fixed] master not compilable since commit 5593b8499

Post by uwestoehr »

Since git commit 5593b8499bd8
I cannot compile master anymore. I get:

Code: Select all

62>D:\FreeCADGit\src\Mod\Part\App\GeometrySurfacePyImp.cpp(173,42): error C2079: 'mkBuilder' uses undefined class 'BRepBuilderAPI_MakeShell'
62>D:\FreeCADGit\src\Mod\Part\App\GeometrySurfacePyImp.cpp(173,62): error C2440: 'initializing': cannot convert from 'initializer list' to 'int'
62>D:\FreeCADGit\src\Mod\Part\App\GeometrySurfacePyImp.cpp(173,51): message : The initializer contains too many elements
I tried a fresh rebuild but this fails too.

Can anybody reproduce this with MSVC?
wmayer wrote: .
User avatar
chennes
Veteran
Posts: 3914
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: master not compilable since commit 5593b8499

Post by chennes »

If you move the

Code: Select all

# include <BRepBuilderAPI_MakeShell.hxx>
outside the precompiled header preprocessor directives it will compile. I don't know if this is the best solution, I leave that to @wmayer to decide.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
wmayer
Founder
Posts: 20319
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: master not compilable since commit 5593b8499

Post by wmayer »

It must also be added to OpenCascadeAll.h. I will push a fix soon...

EDIT: git commit 5bb00636d5
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: master not compilable since commit 5593b8499

Post by uwestoehr »

wmayer wrote: Thu Oct 07, 2021 8:16 am EDIT: git commit 5bb00636d5
Many thanks! It compiles now again without problems.
Post Reply