As a part of the effort, may you have a look at issue #4779 ? I can confirm this bug. The main symptom seems to be that diameter label isn't correctly centered/aligned with the line while radius is correct. Thxabdullah wrote: ↑Thu Nov 11, 2021 1:53 pm The task to refactor ViewProviderSketch::draw() has become quite a daunting effort. Mainly because it has ended up in becoming a major refactor of about every single aspect of ViewProviderSketch where coin is involved. This is at least 70% of the original weight (and it was heavy).
[Merged] Refactoring ViewProviderSketch
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Refactoring ViewProviderSketch
Re: Refactoring ViewProviderSketch
What do I need to do to reproduce it. I create a circle. I put a diameter constraint on it. I do not see the text misaligned or cut. Do I need to do anything special?openBrain wrote: ↑Tue Nov 16, 2021 5:51 pmAs a part of the effort, may you have a look at issue #4779 ? I can confirm this bug. The main symptom seems to be that diameter label isn't correctly centered/aligned with the line while radius is correct. Thxabdullah wrote: ↑Thu Nov 11, 2021 1:53 pm The task to refactor ViewProviderSketch::draw() has become quite a daunting effort. Mainly because it has ended up in becoming a major refactor of about every single aspect of ViewProviderSketch where coin is involved. This is at least 70% of the original weight (and it was heavy).
Re: Refactoring ViewProviderSketch
Here I have nothing special to do. It just reproduces just by adding a diameter constraint to any arc/circle.
If you can't reproduce, I'll try to push a bit the analysis.
Re: Refactoring ViewProviderSketch
JFYI no any issue here about diameter constraint:
OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.20.26326 (Git)
Build type: Unknown
Branch: master
Hash: 2cc570757144422a189b9881e650c3878ec58b13
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)
OS: Debian GNU/Linux 10 (buster) (LXDE/LXDE-pi)
Word size of FreeCAD: 64-bit
Version: 0.20.26326 (Git)
Build type: Unknown
Branch: master
Hash: 2cc570757144422a189b9881e650c3878ec58b13
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: French/France (fr_FR)
Re: Refactoring ViewProviderSketch
Many thanks for that!
Disclaimer: I'm not a developper.
Just 1 question: could this ongoing refactoring allows or ease the export of sketcher's constraint dimensions toward Techdraw views?
I mean about this issue #4181 and this topic or this one
Re: Refactoring ViewProviderSketch
I cannot reproduce it. Which FC version do you have installed, where you can reproduce it?
Re: Refactoring ViewProviderSketch
Not really. A refactoring does not add any new functionality. The changes are not oriented to change the Sketcher data information, but just separating the Coin drawing/node creation/update (management) from other visualisation functions in the ViewProvider, and removing dependencies so that ViewProvider is substantially agnostic of the actual coin implementation used. The ultimate goal to arrive to a good base to implement geometry layers (but implementing this is a separate step, not the goal of the refactoring).-alex- wrote: ↑Tue Nov 16, 2021 9:58 pm Just 1 question: could this ongoing refactoring allows or ease the export of sketcher's constraint dimensions toward Techdraw views?
I mean about this issue #4181 and this topic or this one
Re: Refactoring ViewProviderSketch
I cannot reproduce in the previous version I had (PPA from 1108). I have just upgraded to the latest PPA:
OS: Ubuntu 20.04.3 LTS (MATE/mate)
Word size of FreeCAD: 64-bit
Version: 0.20.
Build type: Release
Branch: unknown
Hash: a26fb4db1adfb387e3c872037ab640722a0b8f0f
Python version: 3.8.10
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.2