Sketcher grid disapperans when document is saved

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
anthonyg
Posts: 51
Joined: Mon Oct 25, 2021 10:30 pm

Sketcher grid disapperans when document is saved

Post by anthonyg »

OS: Debian GNU/Linux 11 (bullseye) (XFCE/lightdm-xsession)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.9.7
Qt version: 5.15.2
Coin version: 4.0.0
OCC version: 7.5.1
Locale: English/United States (en_US)

When in sketcher workbench, when the document is saved the grid disappears, it reappears sometime later while editing the sketch or when clicking Edit -> Refresh (CRTL + R).
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Sketcher grid disapperans when document is saved

Post by openBrain »

Confirmed. Looks like a bug.
Indeed, grid comes back if changing its dimension, or leaving/re-entering sketch (certainly because it forces a redraw).
Will have a look if some time for it. If nothing is done within a week or two, we may open a ticket in the tracker.
---
OS: Ubuntu 21.04 (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.26271
Build type: Release
Branch: master
Hash: d8f38a886ae66f4f3e61df3031c855eb09490489
Python version: 3.9.5
Qt version: 5.15.2
Coin version: 4.0.0
OCC version: 7.5.2
Locale: French/France (fr_FR)
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Sketcher grid disapperans when document is saved

Post by openBrain »

anthonyg wrote: Mon Oct 25, 2021 10:37 pm When in sketcher workbench, when the document is saved the grid disappears, it reappears sometime later while editing the sketch or when clicking Edit -> Refresh (CRTL + R).
That was a very beneficial issue report as it finally pointed me to an incorrect equation in the grid visibility management.
Once fixed, even allows to remove some lines that has been added to workaround the root issue. ;)
Pull request is here : https://github.com/FreeCAD/FreeCAD/pull/5138
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: Sketcher grid disapperans when document is saved

Post by Syres »

openBrain wrote: Tue Nov 02, 2021 6:49 pm Pull request is here : https://github.com/FreeCAD/FreeCAD/pull/5138
So looks like it can be backported to 0.19 branch at the same time as merging into master?
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Sketcher grid disapperans when document is saved

Post by openBrain »

Syres wrote: Wed Nov 03, 2021 8:35 am So looks like it can be backported to 0.19 branch at the same time as merging into master?
Not sure it is of higher importance as this isn't a very inconvenient bug with high occurrence, but it should backport without any issue though.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Sketcher grid disapperans when document is saved

Post by uwestoehr »

openBrain wrote: Wed Nov 03, 2021 11:48 am Not sure it is of higher importance as this isn't a very inconvenient bug with high occurrence, but it should backport without any issue though.
But it was an annoying one. Many thanks for the fix.
I merged the PR and also backported since FC 0.19.3 should be released soon.
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Sketcher grid disapperans when document is saved

Post by openBrain »

uwestoehr wrote: Fri Nov 05, 2021 2:42 am But it was an annoying one. Many thanks for the fix.
I merged the PR and also backported since FC 0.19.3 should be released soon.
Maybe I'm not fair as I don't use grid. :) Anyway trust you to know what should be backported. ;)
Post Reply