IMO the simple way is to create a new branch with master locally on your computer and 'git cherry-pick' my commit.
Getting a PR can be a bit simpler as you have no other remote to add, hence my proposal for a draft PR. Tell me if needed.
IMO the simple way is to create a new branch with master locally on your computer and 'git cherry-pick' my commit.
Hmm I tried that but I get fatal: bad object d42bdf082355330cee9fb22846293a1899b7bc7b
Maybe worth explaining a bit more
Code: Select all
git remote add 0penBrainFork https://github.com/0penBrain/FreeCAD.git # '0penBrainFork' is a free name
git fetch 0penBrainFork sketchConsSelect # 'sketchConsSelect' is the branch name limiting fetching to this branch. It is optional.
Code: Select all
git branch sketchConsSelect FETCH_HEAD
git checkout sketchConsSelect
Code: Select all
git checkout -b test0penBrainCommit # you should run this from an up-to-date master branch
git cherry-pick d42bdf082355330cee9fb22846293a1899b7bc7b
Code: Select all
git fetch upstream pull/5398/head:pr5398 # 'pr5398' is a free name. I assume you have your own fork so official repo is 'upstream'
git checkout pr5398
Thanks for the detailed instruction !
Ok. I'd like to have some more community feedback before unleashing the PR. Is that feature useful/appreciated? Should that be always there, or optionally enabled/disabled? If optional, should that be a preference or a Sketcher task panel option?
Looks doable. Here again community feedback would be good.By the way this could be quite useful in edit mode while not using a tool. Say you want to drag a line or select a line.
Obviously we want to be able to select constrain too when not using a tool.
So what about deactivating constrain selectability when a key is pressed and hold?
So when holding ctrl or an unused key, then the constraints become not selectable.
What do you think?
For this I'll be quite strict about the method. If we go for this other evolution, I'll make another PR as I prefer to keep the PR as atomic as possible (short, easy to review, easy to merge).If you can already merge it as is it would be great.
very useful IMO and I c'ant think of a usecase for selecting a constraint while a tool is active, I don't think it's even possible, they just get preselected and prevent you from using the geometry bellow. So I vote for no preference parameter for this.
I think this would also be useful since sometimes constraints get in the way, however IMO the best solution would be to have some way to control the depth of the selection, in the case of coincident points I don't know of a way of choosing which point is selected, and if you rotate the sketch and edit backwards you straight up can't select endpoints because the edge is above it. Similar issue if a constraint is above another.Looks doable. Here again community feedback would be good.So what about deactivating constrain selectability when a key is pressed and hold?
So when holding ctrl or an unused key, then the constraints become not selectable.
Yes I had this problem while looking at the edit backwards. It's very annoying. Specially because when I do look at the edit backwards I have a reason to do so (some objects that I don't want to hide that are blocking the view)adrianinsaval wrote: ↑Thu Jan 20, 2022 1:44 pm and if you rotate the sketch and edit backwards you straight up can't select endpoints because the edge is above it. Similar issue if a constraint is above another.
I had thought about that too, would be nice to have but it should be generalized considering the configured rendering order not just points I think.
OK, I have a prototype working.