Merge to Master Protocol re CI Checks

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Merge to Master Protocol re CI Checks

Post by wandererfan »

I have some PRs that are waiting for CI check runs. Do we still require the check runs before merging?
User avatar
chennes
Veteran
Posts: 3880
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Merge to Master Protocol re CI Checks

Post by chennes »

"Require" is probably too strong a term -- because Bernd has to manually kick off the CI runs on PRs, and he's on holiday right now, there's a backlog: if you feel like your PR is ready to go, and it passes your tests locally, I think you can go ahead and merge it. If you are just looking for a run of the test suite on another system I'd be happy to run your PRs locally, just tell me what sort of system you want them tested on.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Merge to Master Protocol re CI Checks

Post by wandererfan »

chennes wrote: Fri Jan 21, 2022 3:49 pm
Thanks for the information. The changes are mostly on the Gui side, so they won't really be exercised by the test suite.
Post Reply