[FIXED] Ticket #4835 - Periodic BSpline Control Polygon not Closing Anymore

[louisgag]

Hello,

I hope I did not mix something up in the settings, but my Periodic B-Splines are not closing properly anymore and I suspect it has to do with one of the latest daily updates (stopped working about a week ago).

Any Periodic BSpline I create leaves the last member of the control polygon out, as in the picture
The sketch also has a missing coincidence where the spline should close.

BSplineNotClosing.png (13.98 KiB) Viewed 2284 times

MissingCoincidence.png (16.13 KiB) Viewed 2284 times

Here's the link the the related issue: https://tracker.freecadweb.org/view.php?id=4835 and an example FreeCAD file is attached.

OS: Ubuntu 20.04.3 LTS (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.20.
Build type: Release
Branch: unknown
Hash: 4fb91e4f02636fdb69eb8471dbbbe154dc932872
Python version: 3.8.10
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.2
Locale: C/Default (C)


Can someone confirm this bug?

[chrisb]

The missing coincidence is only indicating that there is no coincidence constraint. This was already in 0.18 so.
And the missing line may not really be an issue. If I open the file in 0.20.26155 the fourth line is shown.

[adrianinsaval]

perhaps abdullah's changes to viewprovider have something to do with this?

[GeneFC]

The fourth line on the right side line shows in 0.20.26761 and does not show in 0.20.26858. I don't have any versions between those numbers.

Gene

[Kunda1]

CC @Abdullah

[abdullah]

CC @Abdullah

Thanks for the ping.

git commit 7aefd2366f182c09683fc696f38c6a57c1b8fa15

[Kunda1]

Nice. I've closed the ticket.

@louisgag can you retest?

[louisgag]

I've just tested with the daily package and the control polygon closes properly.
(The missing coincidence remains, but it doesn't prevent the extrusion and is not an issue, as pointed above by chrisb)

Thanks for having fixed it.