Ticket #6488 - Cone surface returns wrong dv derivative

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: Ticket #6488 - Cone surface returns wrong dv derivative

Post by jnxd »

This might have some implications in https://forum.freecadweb.org/viewtopic.php?f=10&t=20261.
My latest (or last) project: B-spline Construction Project.
wmayer
Founder
Posts: 20298
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Ticket #6488 - Cone surface returns wrong dv derivative

Post by wmayer »

The OCC bug has been fixed now. However, their solution looks a bit different and it should be checked if our suggested fix works correctly in all cases.
wmayer
Founder
Posts: 20298
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Ticket #6488 - Cone surface returns wrong dv derivative

Post by wmayer »

@tanderson69
Have a look at how OCC has fixed the problem.

You can see the differences when computing the derivatives for DN(u, v, 1, 1).

I have applied the fix to our workaround and implemented a unit test to compare the results of the cone and its conversion to a NURBS: git commit b02705d79f
User avatar
tanderson69
Veteran
Posts: 1626
Joined: Thu Feb 18, 2010 1:07 am

Re: Ticket #6488 - Cone surface returns wrong dv derivative

Post by tanderson69 »

wmayer wrote: Fri May 27, 2022 12:50 pm @tanderson69
Have a look at how OCC has fixed the problem.

You can see the differences when computing the derivatives for DN(u, v, 1, 1).

I have applied the fix to our workaround and implemented a unit test to compare the results of the cone and its conversion to a NURBS: git commit b02705d79f
Yeah I looked at occt's fix afterwards and realized what they are trying to do with that function. My occt branch is rebased onto official branches, so after their fix makes into a release I will simply skip my commit.
Post Reply