[To be reworked] Sketcher Tool settings : testers welcome!

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by abdullah »

jnxd wrote: Sun Jun 26, 2022 5:44 pm I was imagining disabling some elements, but that might cut into performance. Some kind of highlighting would be better.
Much "Highlighting" has the bad habit of clashing with UI skins and themes. We have one kind of "highlight" which is converting the value of one parameter to bold when it is "set" (a value has been entered and it is being applied). I more than welcome ideas or code... ;)
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by jnxd »

abdullah wrote: Sun Jun 26, 2022 6:49 pm
jnxd wrote: Sun Jun 26, 2022 5:44 pm I was imagining disabling some elements, but that might cut into performance. Some kind of highlighting would be better.
Much "Highlighting" has the bad habit of clashing with UI skins and themes. We have one kind of "highlight" which is converting the value of one parameter to bold when it is "set" (a value has been entered and it is being applied). I more than welcome ideas or code... ;)
Indeed themes complicate things significantly. A quick alternative would be to put in the "infobar" (idk what its called) saying "setting so and so = 12.34 [mm]" while input is being caught.
My latest (or last) project: B-spline Construction Project.
bleber
Posts: 259
Joined: Thu Jun 30, 2016 5:12 pm

Re: Sketcher Tool settings : testers welcome!

Post by bleber »

I like to test these branch pr, I need a how to indications. Please.
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by abdullah »

bleber wrote: Tue Jun 28, 2022 7:12 am I like to test these branch pr, I need a how to indications. Please.
Thank you.

If you can compile, you may just clone this branch:
https://github.com/abdullahtahiriyo/Fre ... et_testing

If you cannot, then a snap build should come soon...
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by abdullah »

I have merged most of the preconditions.

There might be a bug introduced (I was notified by one of our users in GitHub). I am waiting for a way to reproduce to fix it.

Is somebody willing to do a windows build so that windows users can help test and give their impressions?

Now, I think it is important to get also real feedback on the changes to the toolbar.
Kunda1 wrote: Sat Jun 25, 2022 12:34 pm Ping...
Are there any news on the snap progress?
User avatar
jnxd
Posts: 951
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by jnxd »

abdullah wrote: Wed Jun 29, 2022 12:07 pm
There might be a bug introduced (I was notified by one of our users in GitHub). I am waiting for a way to reproduce to fix it.
Could you share a link to the report?
My latest (or last) project: B-spline Construction Project.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Sketcher Tool settings : testers welcome!

Post by Kunda1 »

abdullah wrote: Wed Jun 29, 2022 12:07 pm Are there any news on the snap progress?
Sorry, can you remind me what PR this is related to and what specific commit you want me to build ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
marioalexis
Posts: 124
Joined: Wed Jun 19, 2019 7:44 pm

Re: Sketcher Tool settings : testers welcome!

Post by marioalexis »

There might be a bug introduced (I was notified by one of our users in GitHub). I am waiting for a way to reproduce to fix it.
With this commit: https://github.com/FreeCAD/FreeCAD/comm ... 8012eb098d

Open new document.
Got to Sketcher workbench.
Create sketch on xy plane.
Create a B-spline.
Pick to create two control points (or more).
Right click to end.
-> Unhandled exception and eventually crash.

Code: Select all

Unhandled std exception in ViewProvider::eventCallback: vector::_M_range_check: __n (which is 9) >= this->size() (which is 9) (Event type: SoKeyboardEvent, object type: SketcherGui::ViewProviderSketch)
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by abdullah »

Kunda1 wrote: Wed Jun 29, 2022 12:25 pm
abdullah wrote: Wed Jun 29, 2022 12:07 pm Are there any news on the snap progress?
Sorry, can you remind me what PR this is related to and what specific commit you want me to build ?
It is not a PR, it is this branch:
https://github.com/abdullahtahiriyo/Fre ... et_testing

If it may be of any help, in this thread, some pages of post ago, a snap was already created for an older version of that branch:
https://forum.freecadweb.org/viewtopic. ... 19#p589919

Thanks and sorry for being misleading ;)
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: Sketcher Tool settings : testers welcome!

Post by abdullah »

marioalexis wrote: Wed Jun 29, 2022 1:02 pm
There might be a bug introduced (I was notified by one of our users in GitHub). I am waiting for a way to reproduce to fix it.
With this commit: https://github.com/FreeCAD/FreeCAD/comm ... 8012eb098d

Open new document.
Got to Sketcher workbench.
Create sketch on xy plane.
Create a B-spline.
Pick to create two control points (or more).
Right click to end.
-> Unhandled exception and eventually crash.

Code: Select all

Unhandled std exception in ViewProvider::eventCallback: vector::_M_range_check: __n (which is 9) >= this->size() (which is 9) (Event type: SoKeyboardEvent, object type: SketcherGui::ViewProviderSketch)
Thank you very much. :D :D

I will look into it ASAP.
Post Reply