Some issues I am unsure how to proceed, and PRs are obviously not the place for research, so I propose to do that here. If your view is that there is no point modernising, or that warnings should be ignored, then please do not come here!
To get the ball rolling:
Code: Select all
virtual void getPoints(std::vector<Base::Vector3d> &Points,
std::vector<Base::Vector3d> &Normals,
float Accuracy, uint16_t flags=0) const;
There are quite a few of these.Clang-Tidy: Default arguments on virtual or override methods are prohibited
And:
Code: Select all
public:
~Segment() override= default;
virtual std::string getName() const=0;
};
And:Clang-Tidy: Function 'getName' should be marked [[nodiscard]]
Code: Select all
private:
/// Private new operator to prevent heap allocation.
void* operator new (std::size_t) = delete;
Clang-Tidy: Deleted member function should be public