DeepSOIC wrote:1. Mark's creation method still limits itself to a circle when I try to draw b>a. Such a circular ellipse with all internal geometry often becomes locked and confuses the solver.
Well, Mark's method defines the major axis, so it is to be expected that you can not "change mind" when setting the 3rd point. I have set the default to my method as this b>a seems to be a big deal (I remember the same problem when I created my method some 50 pages of thread ago). Honestly I have never tried to create a b>a ellipse using Mark's method...
I would not know how to improve the behaviour when locking to a circle. What I do is select the ellipse, hide the internal geometry, resize from edge and show the internal geometry again.
DeepSOIC wrote:2. It is funny that when I delete the ellipse, the internal geometry remains. But it's not a big deal. I just didn't anticipate that.
Yes, it is. This is a drawback of using construction lines instead of another special type of lines (internal geometry lines, if you wish). I mean, the user does not expect construction lines to be deleted. But he would expect internal geometry lines to be deleted. This, of course can be implemented in the future if we feel the need (it should not be a big effort anyway).
DeepSOIC wrote:3. (totally IMHO!) Those volcano-like icons are poorly visible in the dropdown menu (they are apparently 16*16). Especially the one for Mark's construction. I think the old icons were better, and I think the cone should appear only as a general icon for the dropdown, and the dropdown should always invoke a dropdown (conic sections will not be used too often anyway).
It may be a good idea to have 16*16 versions without the cone, if that's possible.
bejant wrote:I have to agree; after seeing your screen grab it is difficult to distinguish one icon from another with the cone.
I have integrated old icons under the conics.
This is a request for Jim: Please make an icon like the one you did before (without the cone) for Mark's method. I hope we are not drawing you crazy with the icons!!!
Looks like we have an arc-of-ellipse creation bug. When I create it with b>a, it jumps.. i.e. appears not exactly where I have drawn it.
DeepSOIC wrote:I wonder, why didn't you reuse the restore/hide internal geometry sketcher tool?
I wanted to. Apparently internal geometry is a UI command and you can not call a UI command from within another command. This we have to revisit because I hate having partially repeated code in two places. It makes maintaining it cumbersome and is not a good coding practice. I think the solution should be general as to allow to call from one command another....
I have integrated your patch. Thanks!! It works perfect now!
BTW, I am proud of myself that git starts to like me, I just had to:
git fetch DeepSOIC
git cherry-pick -x 896372cbae2d5667f72f6ee9e628eea482846156
Note: I have DeepSOIC as a remote of my local repo.
DeepSOIC wrote:When dragging ellipse/arc by edge, center is being dragged instead. Dislike.
I shortly talked about this before. For a circle it is easy due to its circular symmetry, but for an ellipse you would not know what to change (major, minor,...). Because the dragging is effectively a dragging from the center (not a change in the shape), the choice of "jumping to center" is a deliberate decision so that the user is aware that a dragging of the center is what he gets. If someone can come with a better solution that works both, with an ellipse with internal geometry and one without, I would be more than happy to integrate it.
All this fixed/integrated in:
https://github.com/abdullahtahiriyo/Fre ... master.git
https://github.com/abdullahtahiriyo/Fre ... f_creation