Code: Select all
diff --git a/src/CXX/cxxextensions.c b/src/CXX/cxxextensions.c index 28a8e1d..cfab556 100644 --- a/src/CXX/cxxextensions.c +++ b/src/CXX/cxxextensions.c @@ -37,7 +37,7 @@ #include "CXX/WrapPython.h" #if PY_MAJOR_VERSION == 2 -#include "Src/Python2/cxxextensions.c" +#include "Python2/cxxextensions.c" #else -#include "Src/Python3/cxxextensions.c" +#include "Python3/cxxextensions.c" #endif diff --git a/src/CXX/cxxsupport.cxx b/src/CXX/cxxsupport.cxx index 1f2fb43..946e60d 100644 --- a/src/CXX/cxxsupport.cxx +++ b/src/CXX/cxxsupport.cxx @@ -37,7 +37,7 @@ #include "CXX/WrapPython.h" #if PY_MAJOR_VERSION == 2 -#include "Src/Python2/cxxsupport.cxx" +#include "Python2/cxxsupport.cxx" #else -#include "Src/Python3/cxxsupport.cxx" +#include "Python3/cxxsupport.cxx" #endif
Are these patches appropriate to offer upstream to PyCXX project?wmayer wrote:We have to be careful with upgrading PyCXX. For the Windows platform we had to patch the PyCXX in order to export the class declarations to the library. And recently there were made a couple of changes to build with VS 2012.
Does that mean that it could be worth while offering your changes to the PyCXX project? Sorry if this is a silly question.jriegel wrote:My changes regarding VS 2012 was mostly about unclean usage of int and index_type (which are 64 bit on Win64). It was more house keeping then features or bugs...
If you do a diff to the official PyCXX version we use and the sources in master you should get the changes we made.Jürgen/Werner, what would you think is the best way to isolate those changes you did? A diff with a specific verison of PyCXX?