Today I have rebased to master and changed the convert-to-NURBS functionality to use Werner's newly commited functionality. Funny enough, the approximation was indeed different (Top are the approx I used yesterday, bottom the approx by wmayer):
Ok, for circle we know why it is different, it is Werner's own implementation
, but for example for the Ellipse, the OCC approx I used is substantially different from the OCC approx Werner uses (6 poles vs 14 poles). I think that the algo I used produces at least rational bsplines, while the algo Werner uses produces polynomic bsplines (at least for the Ellipse). Why I say that? Well I tried to show the poles:
The ellipse nurbs-ized by Werner's OCC does not deform when enforcing equal weights, whereas the one nurbs-ized using my OCC algo deforms at enforcing equal weights...
To close this deliverable I need to:
1. Fix normal calculation of Nurbs containing straight segments (OCC's Normal fails miserably when the curvature is zero), or at least the effect (crash).
2. Include the icons Alex is doing for the Sketcher... I have to ask him one for the NURBS-ize a shape.
Next one has to do in principle with knots...
EDIT: The branch
https://github.com/abdullahtahiriyo/Fre ... iverable_2