PathGui: ViewProviderPath visual enhancement #625

Here's the place for discussion related to CAM/CNC and the development of the Path module.
realthunder
Posts: 1759
Joined: Tue Jan 03, 2017 10:55 am

Re: PathGui: ViewProviderPath visual enhancement #625

Postby realthunder » Sun Mar 19, 2017 4:32 am

mlampert wrote:yay - can you still verify that the stream operator for doubles doesn't use exponents please
According to cppreference http://en.cppreference.com/w/cpp/io/ios_base/setf, you need to specifically setf with std::scientific to get the exponents. I used std::fixed (fixed decimal) with a given precision (now defaults to 6), which should be equivalent to std::to_string
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
sliptonic
Posts: 1908
Joined: Tue Oct 25, 2011 10:46 pm
Contact:

Re: PathGui: ViewProviderPath visual enhancement #625

Postby sliptonic » Fri Mar 24, 2017 5:37 pm

I really like the improvements to the viewprovider but I'm curious why you switched the path color from green to blue?

This isn't a big deal but all the Path icons use green to show generated paths. The change may cause confusion.

Power users, please weigh in.
realthunder
Posts: 1759
Joined: Tue Jan 03, 2017 10:55 am

Re: PathGui: ViewProviderPath visual enhancement #625

Postby realthunder » Fri Mar 24, 2017 5:42 pm

sliptonic wrote:I really like the improvements to the viewprovider but I'm curious why you switched the path color from green to blue?

This isn't a big deal but all the Path icons use green to show generated paths. The change may cause confusion.

Power users, please weigh in.
Really? That must be a mistake. I was trying different color to distinguish it from the selection color. I remembered I settle down with a lighter green than the normal selection color. Then later I changed to Path selection style to bounding box, so no need to play with the Path color any more. I forgot about the color change. Please make a pull request to change it back.
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
realthunder
Posts: 1759
Joined: Tue Jan 03, 2017 10:55 am

Re: PathGui: ViewProviderPath visual enhancement #625

Postby realthunder » Fri Mar 24, 2017 5:45 pm

The funny thing is that, when I saw your latest screen capture with the blue path, I thought maybe you changed it to distinguish it with selection :lol:
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
realthunder
Posts: 1759
Joined: Tue Jan 03, 2017 10:55 am

Re: PathGui: ViewProviderPath visual enhancement #625

Postby realthunder » Fri Mar 24, 2017 5:48 pm

Ah, I saw the mistake in the code. I'll make a pull request and change it back.
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
realthunder
Posts: 1759
Joined: Tue Jan 03, 2017 10:55 am

Re: PathGui: ViewProviderPath visual enhancement #625

Postby realthunder » Fri Mar 24, 2017 8:34 pm

sliptonic wrote:I'm curious why you switched the path color from green to blue?
Color restored, and it's been merged to the master.
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
chrisb
Posts: 28040
Joined: Tue Mar 17, 2015 9:14 am

Re: PathGui: ViewProviderPath visual enhancement #625

Postby chrisb » Fri Mar 24, 2017 10:20 pm

I had thought it was to distinguish different versions at a glance :) .