The PR hasn't been merged yet.Konstantin wrote: ↑Mon Aug 28, 2017 6:21 am[Edited] It seems that I have again that problem, when I pull from git, but somehow old version remains.
The PR hasn't been merged yet.Konstantin wrote: ↑Mon Aug 28, 2017 6:21 am[Edited] It seems that I have again that problem, when I pull from git, but somehow old version remains.
Oooopsmlampert wrote: ↑Mon Aug 28, 2017 6:42 amThe PR hasn't been merged yet.Konstantin wrote: ↑Mon Aug 28, 2017 6:21 am[Edited] It seems that I have again that problem, when I pull from git, but somehow old version remains.
Confirmed - if I was in marketing I would call it a feature.
That version is from April, before sliptonic changed all ops over to Path.Area. There were a lot of pockets that implementation couldn't handle - and I guess we neglected to test the simple cases
Code: Select all
PathLog.error(translate("Path", "Invalid Cutting Edge Angle %.2f, must be <90° and >=0°") % tool.CuttingEdgeAngle)
Code: Select all
OS: "Manjaro Linux"
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.11935 (Git)
Build type: Release
Branch: master
Hash: a5bc70cca0d2eaa56709603521650ccb3d8d926c
Python version: 2.7.13
Qt version: 5.9.1
Coin version: 3.1.3
OCC version: 6.9.1.oce-0.18
Locale: Russian/Russia (ru_RU)
Code: Select all
OS: "Manjaro Linux"
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.11935 (Git)
Build type: Release
Branch: master
Hash: a5bc70cca0d2eaa56709603521650ccb3d8d926c
Python version: 2.7.13
Qt version: 5.9.1
Coin version: 3.1.3
OCC version: 6.9.1.oce-0.18
Locale: C/Default (C)
Done: issue #3170
Who would have thought I would ever install Russian on any of my boxes ....Konstantin wrote: ↑Tue Aug 29, 2017 9:59 amOk, after getting in trouble with ccache I finaly built FreeCAD today (with Qt5 and Pyside2). Now I can see drilling menu, but segfault (when drillbit cutting angle > 90°) is not fixed. How to reproduce:It looks that problem in line 757
- Create Job,
- Remove Default tool
- Modify some tool to have angle bigger than 90°, add it to the Job
- Press Drilling button
Code: Select all
PathLog.error(translate("Path", "Invalid Cutting Edge Angle %.2f, must be <90° and >=0°") % tool.CuttingEdgeAngle)
I never said I'm against your solution, we just haven't decided what we want to do there and currently have more basic functionality to address. We already have a precedence of behaviour and I don't want to replace that with another one if it's quite likely to be replaced again.And a bit offtopic here: I still don't understand, why you are against my solution of checking the angle ...