Discussion on Dressups and Tool Controllers

Here's the place for discussion related to CAM/CNC and the development of the Path module.
User avatar
JoshM
Posts: 419
Joined: Thu Oct 05, 2017 5:34 pm
Location: New Hampshire

Re: CAM simulation for the Path Workbench

Postby JoshM » Thu Mar 01, 2018 7:04 pm

sliptonic wrote:
Thu Mar 01, 2018 6:47 pm
I agree. That's a problem. Want to add a bug?
Sure will.
-j
schnebeck
Posts: 123
Joined: Thu Jun 22, 2017 8:04 pm

Re: CAM simulation for the Path Workbench

Postby schnebeck » Thu Mar 01, 2018 11:08 pm

Talking about dress-up ops:
me as a user wonders why can I not use some Dress-Up operations in a nested way e.g. Helix ramp contour + Lead in/out?
For me some combinations of path Dress-Up OPs could be quite useful that are by now not allowed. So when there are some modification necessary for improving Dress-Up, maybe its possible to use these Ops in an object-oriented way. An OP could inherit the TC from the sub-object. The sub-object could be an already nested structure, which got the TC inherit from a base object (a basic Path operation).

Bye

Thorsten
User avatar
bill
Posts: 376
Joined: Fri Jan 09, 2015 9:25 pm

Re: CAM simulation for the Path Workbench

Postby bill » Fri Mar 02, 2018 2:59 pm

sliptonic wrote:
Thu Mar 01, 2018 6:22 pm
it would be wrong to add a TC to the dressup
Yes, I agree with this because: a Path:Dress-Up is just that, a path modification, and not a tool-change.

But for the sake of data-structures, most probably should look like any other operation making its interoperability with activities such as Sim well defined/standardized.

If some user(like me) needs to chase the profile with a chamfer, then copy/clone the profile operation, set an offset, and utilize another tool selection.
This is why Ive always wanted to be able to clone an operation, preserving all op detail; then just change the tool selection.

Additionally, I think this topic should be its own thread and needs to be moved since this borders on thread hijacking! :lol: :lol: :lol: :lol:
User avatar
sliptonic
Posts: 1620
Joined: Tue Oct 25, 2011 10:46 pm

Re: CAM simulation for the Path Workbench

Postby sliptonic » Fri Mar 02, 2018 3:13 pm

bill wrote:
Fri Mar 02, 2018 2:59 pm
sliptonic wrote:
Thu Mar 01, 2018 6:22 pm
it would be wrong to add a TC to the dressup
If some user(like me) needs to chase the profile with a chamfer, then copy/clone the profile operation, set an offset, and utilize another tool selection.
This is why Ive always wanted to be able to clone an operation, preserving all op detail; then just change the tool selection.

Additionally, I think this topic should be its own thread and needs to be moved since this borders on thread hijacking! :lol: :lol: :lol: :lol:
I agree about thread-jacking but I'm not a forum admin. As for the cloning, don't we already have this?
snapshot-3.png
snapshot-3.png (142.92 KiB) Viewed 363 times
chrisb
Posts: 21212
Joined: Tue Mar 17, 2015 9:14 am

Re: CAM simulation for the Path Workbench

Postby chrisb » Fri Mar 02, 2018 4:42 pm

I can split it, but I have to get it right the first time, because I am afraid will not be able to merge things later. So where should I split it:
either here: https://forum.freecadweb.org/viewtopic. ... 30#p217733
or here: https://forum.freecadweb.org/viewtopic. ... 40#p217869
User avatar
sliptonic
Posts: 1620
Joined: Tue Oct 25, 2011 10:46 pm

Re: CAM simulation for the Path Workbench

Postby sliptonic » Fri Mar 02, 2018 4:49 pm

chrisb wrote:
Fri Mar 02, 2018 4:42 pm
I can split it, but I have to get it right the first time, because I am afraid will not be able to merge things later. So where should I split it:
either here: https://forum.freecadweb.org/viewtopic. ... 30#p217733
or here: https://forum.freecadweb.org/viewtopic. ... 40#p217869
I think at 217733.
chrisb
Posts: 21212
Joined: Tue Mar 17, 2015 9:14 am

Re: Discussion on Dressups and Tool Controllers

Postby chrisb » Fri Mar 02, 2018 5:12 pm

Splitting is done.
herbk
Posts: 1696
Joined: Mon Nov 03, 2014 3:45 pm
Location: Windsbach, Bavarya (Germany)

Re: CAM simulation for the Path Workbench

Postby herbk » Fri Mar 02, 2018 6:41 pm

Hi Sliptonic,
sliptonic wrote:
Fri Mar 02, 2018 3:13 pm
As for the cloning, don't we already have this?
Yes we have, - but it dosn't work on a operation with a dressup. Also array dosn't work on a operation with dressup.
Last tested with AppImage

OS: "openSUSE Leap 42.3"
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13340 (Git) AppImage
Build type: None
Branch: master
Hash: 29864ff82173e501e220e754ccfe845b53990908
Python version: 2.7.6
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: German/Germany (de_DE)
Last edited by herbk on Sat Mar 10, 2018 12:06 pm, edited 1 time in total.
Gruß Herbert
User avatar
jmr
Posts: 31
Joined: Fri Feb 09, 2018 3:32 pm

Re: Discussion on Dressups and Tool Controllers

Postby jmr » Fri Mar 02, 2018 8:22 pm

Hey!
Another thing to add is that all Dressups should get the Active property of the parent operation. Do You agree?
for RampEntry, when the Active of the parent is toggled I get the red exclamation and it does not recompute, then I get the old ramp entry code without the pocket... or like that, while Dogbone disappears correctly. This toggle Active thing is very useful when testing parts of code and then moving on to next operation, or when one operation failed.
Could it also be toggled together with visibility?
roivai
Posts: 117
Joined: Thu Feb 02, 2017 5:29 pm
Location: Oulu, Finland

Re: CAM simulation for the Path Workbench

Postby roivai » Sat Mar 10, 2018 11:33 am

herbk wrote:
Fri Mar 02, 2018 6:41 pm
Yes we have, - but it dosn't work on a operation with a dressup. Also array dosn't work on a püeration with dressup.
Last tested with AppImage
I fixed this one - made PathArray to accept Dressups. The commit is here:
https://github.com/pekkaroi/FreeCAD/com ... 0c1f4d2da1

Before pull request - I'd like to have comment from sliptonic or mlampert about the usage of

Code: Select all

isinstance(obj.Proxy, PathScripts.PathOp.ObjectOp)
and
obj.isDerivedFrom("Path::Feature")
It is not very clear to me what is defined as PathOp.ObjectOp and what is derived from Path::Feature. That condition I ended up with to enable the PathArray is not very sensible IMO:

Code: Select all

 return isinstance(obj.Proxy, PathScripts.PathOp.ObjectOp) or (obj.isDerivedFrom("Path::Feature") and "Dressup" in obj.Name)
Should this be inculded in 0.17?