v0.17-0.18 - Error in postprocessor

[fbx]

Hi,

it seems that PathPost.py has a problem postprocessing. It smashes
trying to open the file save dialog. If I modify the script to avoid opening the dialog
then everything else seems to work and I get sane outputs.
I'd fix it if I understood where QtGui.qApp should be initialized, but I have no idea.
Why is it uninitialized ?

Cheers
fbx


------------------
Path workbench activated
PathPost.DEBUG: about to postprocess job: Job
PathPost.DEBUG: obj: MillFace
PathPost.DEBUG: obj: Pocket_Shape
PathPost.DEBUG: obj: Profile_Edges
PathPost.DEBUG: obj: Pocket_Shape001
PathPost.DEBUG: obj: TagDressup
PathPost.DEBUG: obj: Profile_Faces002
Running the Python command 'Path_Post' failed:
Traceback (most recent call last):
File "/Applications/FreeCAD.app/Contents/Mod/Path/PathScripts/PathPost.py", line 259, in Activated
(fail, rc) = self.exportObjectsWith(postlist, job)
File "/Applications/FreeCAD.app/Contents/Mod/Path/PathScripts/PathPost.py", line 187, in exportObjectsWith
filename = self.resolveFileName(job)
File "/Applications/FreeCAD.app/Contents/Mod/Path/PathScripts/PathPost.py", line 140, in resolveFileName
foo = QtGui.QFileDialog.getSaveFileName(QtGui.qApp.activeWindow(), "Output File", filename)

'NoneType' object has no attribute 'activeWindow'
----------------------


My version data:
OS: Mac OS X
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13511 (Git)
Build type: Release
Branch: (HEAD detached at 5773170)
Hash: 5773170777f424c932f2088ef92d5f664b7d3c23
Python version: 2.7.14
Qt version: 5.10.1
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/Switzerland (en_CH)

[sgrogan]

I'd fix it if I understood where QtGui.qApp should be initialized, but I have no idea.

There is a pending Pull Request

[berka]

There is a pending Pull Request

I ran into this on 0.17; both the April release and the Latest August release.
I see that the pull request was for :master. Any chance this fix can be applied to 0.17 branch too?


OS: Mac OS X
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13541 (Git)
Build type: Release
Branch: releases/FreeCAD-0-17
Hash: 9948ee4f1570df9216862a79705afb367b2c6ffb
Python version: 2.7.14
Qt version: 5.10.1
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedStates (en_US)

[chrisb]

Is there a reason why you don't use 0.18? The release is before the doors and I guess noone will backport things to 0.17.

[berka]

I didn't know 0.18 was that close. Is there a release candidate? That's a lot faster than 0.17 took.
Anyway, I'd still rather use a stable version. There are understandably changes to objects and files that break from build-to-build on the development version. I can't risk having my projects broken because of that.
Knowing the fix, I was able to use sed to replace all "qApp" with "QApplication" and fix my problem.

[chrisb]

I didn't know 0.18 was that close. Is there a release candidate? That's a lot faster than 0.17 took.
Anyway, I'd still rather use a stable version. There are understandably changes to objects and files that break from build-to-build on the development version. I can't risk having my projects broken because of that.
Knowing the fix, I was able to use sed to replace all "qApp" with "QApplication" and fix my problem.

You can give it a try and install both versions in parallel. 0.18 seems to be more stable than 0.17, many things have been fixed and smoothed.