Ramp entry (helix) too steep

[chrisb]

Any comments before I make a PR?

Thank you!

[GeneFC]

The term "IgnoreAbove" probably carries little meaning unless the user already understands the shorthand notation.

If I understand the logic, then "BeginAtStartDepth" might be a bit clearer.

Either way, a nice update.

Gene

[roivai]

The term "IgnoreAbove" probably carries little meaning unless the user already understands the shorthand notation.

If I understand the logic, then "BeginAtStartDepth" might be a bit clearer.

Good suggestion. Actually, I went even further and called them UseStartDepth and DressupStartDepth. PR is here:
https://github.com/FreeCAD/FreeCAD/pull/1467

[herbk]

Hi roivai,

ping

there is a new problem if using the ramp entry dressup: it only removes the ramp, not the whole material.

rampentry.jpg (47.58 KiB) Viewed 290 times

Th screenshot is taken at a Millface OP, but the behavior is the same at Pocket OP and Pocket 3D.

[roivai]

there is a new problem if using the ramp entry dressup: it only removes the ramp, not the whole material.

rampentry.jpg

Th screenshot is taken at a Millface OP, but the behavior is the same at Pocket OP and Pocket 3D.

I suppose you are using helix method? I think I have seen that at some point, then was not able to reproduce it and forgot the whole thing.. Basically what happens (I think) is that is does consider that round as the last round for some reason, maybe rounding error or something, so it does not add the final "flat" cutting loop. Can you send me that file?

[herbk]

Hi roivai,

yes it's the helix ramp, - and file is attached.

[roivai]

Hi roivai,

yes it's the helix ramp, - and file is attached.

Thanks for the file. The bug was even more obvious than I originally expected. When the dressup was searching for minimum Z on the path, it included the first edge from (0,0,0) to actual starting position. So it always found 0 as the minimum Z if the actual path did not go below zero. It seems that I've never tried this with a model where the bottom of the cut is above zero. Not very good testing coverage.

Pull request is at https://github.com/FreeCAD/FreeCAD/pull/1746