Ramp entry (helix) too steep

Here's the place for discussion related to CAM/CNC and the development of the Path module.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
chrisb
Veteran
Posts: 53919
Joined: Tue Mar 17, 2015 9:14 am

Re: Ramp entry (helix) too steep

Post by chrisb »

roivai wrote: Tue May 22, 2018 7:35 pmAny comments before I make a PR?
Thank you!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: Ramp entry (helix) too steep

Post by GeneFC »

The term "IgnoreAbove" probably carries little meaning unless the user already understands the shorthand notation.

If I understand the logic, then "BeginAtStartDepth" might be a bit clearer.

Either way, a nice update.

Gene
roivai
Posts: 117
Joined: Thu Feb 02, 2017 5:29 pm
Location: Oulu, Finland

Re: Ramp entry (helix) too steep

Post by roivai »

GeneFC wrote: Wed May 23, 2018 2:52 pm The term "IgnoreAbove" probably carries little meaning unless the user already understands the shorthand notation.

If I understand the logic, then "BeginAtStartDepth" might be a bit clearer.
Good suggestion. Actually, I went even further and called them UseStartDepth and DressupStartDepth. PR is here:
https://github.com/FreeCAD/FreeCAD/pull/1467
herbk
Veteran
Posts: 2657
Joined: Mon Nov 03, 2014 3:45 pm
Location: Windsbach, Bavarya (Germany)

Re: Ramp entry (helix) too steep

Post by herbk »

Hi roivai,
roivai wrote: Wed May 23, 2018 5:55 pm ping
there is a new problem if using the ramp entry dressup: it only removes the ramp, not the whole material.
rampentry.jpg
rampentry.jpg (47.58 KiB) Viewed 920 times
Th screenshot is taken at a Millface OP, but the behavior is the same at Pocket OP and Pocket 3D.
Gruß Herbert
roivai
Posts: 117
Joined: Thu Feb 02, 2017 5:29 pm
Location: Oulu, Finland

Re: Ramp entry (helix) too steep

Post by roivai »

herbk wrote: Mon Oct 22, 2018 8:31 pm
there is a new problem if using the ramp entry dressup: it only removes the ramp, not the whole material.

rampentry.jpg

Th screenshot is taken at a Millface OP, but the behavior is the same at Pocket OP and Pocket 3D.
I suppose you are using helix method? I think I have seen that at some point, then was not able to reproduce it and forgot the whole thing.. Basically what happens (I think) is that is does consider that round as the last round for some reason, maybe rounding error or something, so it does not add the final "flat" cutting loop. Can you send me that file?
herbk
Veteran
Posts: 2657
Joined: Mon Nov 03, 2014 3:45 pm
Location: Windsbach, Bavarya (Germany)

Re: Ramp entry (helix) too steep

Post by herbk »

Hi roivai,

yes it's the helix ramp, - and file is attached.
Attachments
Halter_6_cells.fcstd
(40.98 KiB) Downloaded 35 times
Gruß Herbert
roivai
Posts: 117
Joined: Thu Feb 02, 2017 5:29 pm
Location: Oulu, Finland

Re: Ramp entry (helix) too steep

Post by roivai »

herbk wrote: Wed Oct 24, 2018 8:17 pm Hi roivai,

yes it's the helix ramp, - and file is attached.
Thanks for the file. The bug was even more obvious than I originally expected. When the dressup was searching for minimum Z on the path, it included the first edge from (0,0,0) to actual starting position. So it always found 0 as the minimum Z if the actual path did not go below zero. It seems that I've never tried this with a model where the bottom of the cut is above zero. Not very good testing coverage.

Pull request is at https://github.com/FreeCAD/FreeCAD/pull/1746
Post Reply